Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Side by Side Diff: cc/layers/layer_impl_unittest.cc

Issue 1736073002: cc: Move SyncedScrollOffset to scroll tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix after rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/layers/layer_impl.h" 5 #include "cc/layers/layer_impl.h"
6 6
7 #include "cc/animation/mutable_properties.h" 7 #include "cc/animation/mutable_properties.h"
8 #include "cc/layers/painted_scrollbar_layer_impl.h" 8 #include "cc/layers/painted_scrollbar_layer_impl.h"
9 #include "cc/layers/solid_color_scrollbar_layer_impl.h" 9 #include "cc/layers/solid_color_scrollbar_layer_impl.h"
10 #include "cc/output/filter_operation.h" 10 #include "cc/output/filter_operation.h"
(...skipping 538 matching lines...) Expand 10 before | Expand all | Expand 10 after
549 EXPECT_VECTOR_EQ(scroll_offset, layer()->BaseScrollOffset()); 549 EXPECT_VECTOR_EQ(scroll_offset, layer()->BaseScrollOffset());
550 } 550 }
551 551
552 TEST_F(LayerImplScrollTest, ApplySentScrollsNoListener) { 552 TEST_F(LayerImplScrollTest, ApplySentScrollsNoListener) {
553 gfx::ScrollOffset scroll_offset(10, 5); 553 gfx::ScrollOffset scroll_offset(10, 5);
554 gfx::Vector2dF scroll_delta(20.5f, 8.5f); 554 gfx::Vector2dF scroll_delta(20.5f, 8.5f);
555 gfx::Vector2d sent_scroll_delta(12, -3); 555 gfx::Vector2d sent_scroll_delta(12, -3);
556 556
557 layer()->PushScrollOffsetFromMainThread(scroll_offset); 557 layer()->PushScrollOffsetFromMainThread(scroll_offset);
558 layer()->ScrollBy(sent_scroll_delta); 558 layer()->ScrollBy(sent_scroll_delta);
559 layer()->PullDeltaForMainThread(); 559 layer()->synced_scroll_offset()->PullDeltaForMainThread();
560 layer()->SetCurrentScrollOffset(scroll_offset + 560 layer()->SetCurrentScrollOffset(scroll_offset +
561 gfx::ScrollOffset(scroll_delta)); 561 gfx::ScrollOffset(scroll_delta));
562 562
563 EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, scroll_delta), 563 EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, scroll_delta),
564 layer()->CurrentScrollOffset()); 564 layer()->CurrentScrollOffset());
565 EXPECT_VECTOR_EQ(scroll_delta, layer()->ScrollDelta()); 565 EXPECT_VECTOR_EQ(scroll_delta, layer()->ScrollDelta());
566 EXPECT_VECTOR_EQ(scroll_offset, layer()->BaseScrollOffset()); 566 EXPECT_VECTOR_EQ(scroll_offset, layer()->BaseScrollOffset());
567 567
568 layer()->ApplySentScrollDeltasFromAbortedCommit(); 568 layer()->synced_scroll_offset()->AbortCommit();
569 569
570 EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, scroll_delta), 570 EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, scroll_delta),
571 layer()->CurrentScrollOffset()); 571 layer()->CurrentScrollOffset());
572 EXPECT_VECTOR_EQ(scroll_delta - sent_scroll_delta, layer()->ScrollDelta()); 572 EXPECT_VECTOR_EQ(scroll_delta - sent_scroll_delta, layer()->ScrollDelta());
573 EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, sent_scroll_delta), 573 EXPECT_VECTOR_EQ(gfx::ScrollOffsetWithDelta(scroll_offset, sent_scroll_delta),
574 layer()->BaseScrollOffset()); 574 layer()->BaseScrollOffset());
575 } 575 }
576 576
577 TEST_F(LayerImplScrollTest, ScrollUserUnscrollableLayer) { 577 TEST_F(LayerImplScrollTest, ScrollUserUnscrollableLayer) {
578 gfx::ScrollOffset scroll_offset(10, 5); 578 gfx::ScrollOffset scroll_offset(10, 5);
(...skipping 12 matching lines...) Expand all
591 gfx::Vector2dF scroll_delta(12, 18); 591 gfx::Vector2dF scroll_delta(12, 18);
592 592
593 host_impl().CreatePendingTree(); 593 host_impl().CreatePendingTree();
594 594
595 layer()->PushScrollOffsetFromMainThread(scroll_offset); 595 layer()->PushScrollOffsetFromMainThread(scroll_offset);
596 gfx::Vector2dF unscrolled = layer()->ScrollBy(scroll_delta); 596 gfx::Vector2dF unscrolled = layer()->ScrollBy(scroll_delta);
597 597
598 EXPECT_VECTOR_EQ(gfx::Vector2dF(0, 0), unscrolled); 598 EXPECT_VECTOR_EQ(gfx::Vector2dF(0, 0), unscrolled);
599 EXPECT_VECTOR_EQ(gfx::Vector2dF(22, 23), layer()->CurrentScrollOffset()); 599 EXPECT_VECTOR_EQ(gfx::Vector2dF(22, 23), layer()->CurrentScrollOffset());
600 600
601 layer()->PullDeltaForMainThread(); 601 layer()->synced_scroll_offset()->PullDeltaForMainThread();
602 602
603 scoped_ptr<LayerImpl> pending_layer = LayerImpl::Create( 603 scoped_ptr<LayerImpl> pending_layer = LayerImpl::Create(
604 host_impl().sync_tree(), layer()->id(), layer()->synced_scroll_offset()); 604 host_impl().sync_tree(), layer()->id(), layer()->synced_scroll_offset());
605 pending_layer->PushScrollOffsetFromMainThread(layer()->CurrentScrollOffset()); 605 pending_layer->PushScrollOffsetFromMainThread(layer()->CurrentScrollOffset());
606 606
607 pending_layer->PushPropertiesTo(layer()); 607 pending_layer->PushPropertiesTo(layer());
608 608
609 EXPECT_VECTOR_EQ(gfx::Vector2dF(22, 23), layer()->CurrentScrollOffset()); 609 EXPECT_VECTOR_EQ(gfx::Vector2dF(22, 23), layer()->CurrentScrollOffset());
610 EXPECT_VECTOR_EQ(layer()->CurrentScrollOffset(), 610 EXPECT_VECTOR_EQ(layer()->CurrentScrollOffset(),
611 pending_layer->CurrentScrollOffset()); 611 pending_layer->CurrentScrollOffset());
612 } 612 }
613 613
614 } // namespace 614 } // namespace
615 } // namespace cc 615 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698