Add background_tile_view for tiling an image as UI background (about box need...

Add background_tile_view for tiling an image as UI background (about box needed it)
Added restart_browser as a helper like Views helper for putting up a request for the user to restart.
Added a new string needed for Mac style alerts to go with the existing restart string.
Make Mac Chromium use a custom about box.
Give Chromium and Google Chrome an about box that matches the one on other platforms
Use all the existing UI strings for the about box so we get credits, copy rights, etc.

TEST=New aboutbox for Chromium and Google Chrome.  About box should be fully l10n and size as needed.  Chrome update messaging should more match windows and be localized.
BUG=13219, 19020
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24737

[John Grabowski, 2009-08-28 14:46:46]

LGTM modulo UI dude feedback (if not obtained already) on 
- modal Restart dialog vs restart text message in box
- background image instead of background_gradient_view.mm

If you can't get feedback let me know and I'll tackle^H^H^H^H^Hgently request
time from Cole.

(p.s. thx for taking care of this)

http://codereview.chromium.org/173606/diff/2001/2004
File chrome/browser/app_controller_mac.mm (left):

http://codereview.chromium.org/173606/diff/2001/2004#oldcode631
Line 631: #if !defined(GOOGLE_CHROME_BUILD)
Add info to TEST= in the bug asking to check for the credits link now that it's
there in an unbranded custom about box.  Also be clear to state that everything
else needs a branded build for testing.

http://codereview.chromium.org/173606/diff/2001/2010
File chrome/browser/cocoa/about_window_controller.h (right):

http://codereview.chromium.org/173606/diff/2001/2010#newcode31
Line 31: NSString *newVersionAvailable_;  // The version we got told about by
Keystone
scoped_nsobject

http://codereview.chromium.org/173606/diff/2001/2006
File chrome/browser/cocoa/about_window_controller.mm (right):

http://codereview.chromium.org/173606/diff/2001/2006#newcode27
Line 27: const int kUpdateInstallFailed = 128;
static or namespace{} these.

http://codereview.chromium.org/173606/diff/2001/2006#newcode37
Line 37: namespace {
Simple unit tests for the Append... functions?

http://codereview.chromium.org/173606/diff/2001/2006#newcode188
Line 188: - (void)dealloc {
No need if newVersionAvailable_ is scoped_nsobject

http://codereview.chromium.org/173606/diff/2001/2006#newcode195
Line 195: // TODO: Is this what's on disk or what we launched with?
It is what we launched with, which is why it doesn't change when we auto-update.

http://codereview.chromium.org/173606/diff/2001/2006#newcode315
Line 315: // TODO: We really should check to see if what is on disk is newer
then what
TODO --> TODO(thomasvl)

http://codereview.chromium.org/173606/diff/2001/2012
File chrome/browser/cocoa/background_tile_view.h (right):

http://codereview.chromium.org/173606/diff/2001/2012#newcode10
Line 10: // A custom view that draws a image tiled as the background.  This
isn't meant
Why do we have a background image and not a gradient view for the about box?

http://codereview.chromium.org/173606/diff/2001/2008
File chrome/browser/cocoa/background_tile_view_unittest.mm (right):

http://codereview.chromium.org/173606/diff/2001/2008#newcode28
Line 28: TEST_F(BackgroundTileViewTest, AddRemove) {
<3 whole file

http://codereview.chromium.org/173606/diff/2001/2007
File chrome/browser/cocoa/restart_browser.h (right):

http://codereview.chromium.org/173606/diff/2001/2007#newcode17
Line 17: void RequestRestart(NSWindow *parent);
NSWindow*

http://codereview.chromium.org/173606/diff/2001/2005
File chrome/browser/cocoa/restart_browser.mm (right):

http://codereview.chromium.org/173606/diff/2001/2005#newcode12
Line 12: @interface RestartHelper : NSObject {
The code in here is all fine, but I personally would prefer a text string
instead of a modal dialog.  If not done already, please ping Cole et al for an
opinion here.

[TVL, 2009-08-28 15:26:38]

http://codereview.chromium.org/173606/diff/2001/2004
File chrome/browser/app_controller_mac.mm (left):

http://codereview.chromium.org/173606/diff/2001/2004#oldcode631
Line 631: #if !defined(GOOGLE_CHROME_BUILD)
On 2009/08/28 14:46:46, John Grabowski wrote:
> Add info to TEST= in the bug asking to check for the credits link now that
it's
> there in an unbranded custom about box.  Also be clear to state that
everything
> else needs a branded build for testing.

Links don't work, my NSTexitField foo wasn't strong enough, even though I
follows Apple's samples.  I already filed http://crbug.com/20493 so someone with
better skillz can come back through and hit this.

http://codereview.chromium.org/173606/diff/2001/2006
File chrome/browser/cocoa/about_window_controller.mm (right):

http://codereview.chromium.org/173606/diff/2001/2006#newcode37
Line 37: namespace {
On 2009/08/28 14:46:46, John Grabowski wrote:
> Simple unit tests for the Append... functions?

Then I have to export them, which is sort the catch22.  :(

http://codereview.chromium.org/173606/diff/2001/2006#newcode315
Line 315: // TODO: We really should check to see if what is on disk is newer
then what
On 2009/08/28 14:46:46, John Grabowski wrote:
> TODO --> TODO(thomasvl)

nope, was already filed http://crbug.com/13165, added the bug reference, not
sure who will do it in the end.

http://codereview.chromium.org/173606/diff/2001/2012
File chrome/browser/cocoa/background_tile_view.h (right):

http://codereview.chromium.org/173606/diff/2001/2012#newcode10
Line 10: // A custom view that draws a image tiled as the background.  This
isn't meant
On 2009/08/28 14:46:46, John Grabowski wrote:
> Why do we have a background image and not a gradient view for the about box?

gradient can use theme, we want to match the windows about box which isn't
themed.  the tile provides the brackground and sep at the bottom of the white
area.  also makes sure it matches the image used in the about box.

http://codereview.chromium.org/173606/diff/2001/2008
File chrome/browser/cocoa/background_tile_view_unittest.mm (right):

http://codereview.chromium.org/173606/diff/2001/2008#newcode28
Line 28: TEST_F(BackgroundTileViewTest, AddRemove) {
On 2009/08/28 14:46:46, John Grabowski wrote:
> <3 whole file

updated for image unset and set.

http://codereview.chromium.org/173606/diff/2001/2005
File chrome/browser/cocoa/restart_browser.mm (right):

http://codereview.chromium.org/173606/diff/2001/2005#newcode12
Line 12: @interface RestartHelper : NSObject {
On 2009/08/28 14:46:46, John Grabowski wrote:
> The code in here is all fine, but I personally would prefer a text string
> instead of a modal dialog.  If not done already, please ping Cole et al for an
> opinion here.

Just following windows lead, this maps to some code on windows also that is used
from prefs also (where a bounce could be needed, so this gives us the
functionally same helper.

[John Grabowski, 2009-08-28 16:39:42]

Still LGTM

Funny thing to note.
Many CLs fix a bug, but the author files a new bug as follow-up.

For this CL, 2 bugs are fixed (13219,19020).
But adds only one (20493).
I am excited that we finally have a CL which DROPS the bug count!

http://codereview.chromium.org/173606/diff/2001/2006
File chrome/browser/cocoa/about_window_controller.mm (right):

http://codereview.chromium.org/173606/diff/2001/2006#newcode37
Line 37: namespace {
On 2009/08/28 15:26:38, TVL wrote:
> On 2009/08/28 14:46:46, John Grabowski wrote:
> > Simple unit tests for the Append... functions?
> 
> Then I have to export them, which is sort the catch22.  :(

One option: In header add
namespace about_box_string_utils {
  // now add functions
}