Issue 173604: Adds a default icon to the install dialog if the extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173604: Adds a default icon to the install dialog if the extension (Closed)

Created:
11 years, 3 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Adds a default icon to the install dialog if the extension doesn't specify one. This icon came from Crystal Clear [1] and is licensed under LGPL. [1] http://commons.wikimedia.org/wiki/Crystal_Clear BUG=20510 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24754

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -17 lines)			Patch
M	chrome/browser/browser_resources.grd	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.cc	View	3 chunks	+7 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/default_extension_icon_128.png	View	Binary file		0 comments	Download
M	chrome/browser/views/extensions/extension_install_prompt.cc	View	3 chunks	+10 lines, -17 lines	0 comments	Download

Total messages: 2 (0 generated)

Erik does not do reviews

11 years, 3 months ago (2009-08-28 14:51:11 UTC) #2

LGTM

I assume this is a placeholder since we're not using other similar icons?  If
so, file a bug and associate it with this CL.