Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
173593002:
HTML5 Canvas should avoid converting rotation angle to degrees (Closed)
|
Created:
6 years, 10 months ago by zino Modified:
6 years, 9 months ago CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, dglazkov+blink, Rik, adamk+blink_chromium.org, Stephen Chennney, aandrey+blink_chromium.org, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Visibility:
Public. |
DescriptionrotateRadians function was added to AffineTransform class.
We can switch from some rotate() to rotateRadians().
https://codereview.chromium.org/166273019/
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168929
Patch Set 1 #Patch Set 2 : #Patch Set 3 : rebase #
Messages
Total messages: 32 (0 generated)
On 2014/02/22 04:34:20, zino wrote: LGTM
The CQ bit was checked by jinho.bang@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/173593002/30001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...
The CQ bit was checked by jinho.bang@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/173593002/30001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...
The CQ bit was checked by jinho.bang@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/173593002/30001
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...
lgtm. nits: s/frome/from/ in description.
btw, it's shocking that we've converted rad->deg->rad until now.
On 2014/03/04 17:29:25, dshwang wrote: > lgtm. > > nits: s/frome/from/ in description. Thank you for review :) I updated description.
The CQ bit was checked by jinho.bang@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/173593002/30001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink, win_blink_rel
The CQ bit was checked by jinho.bang@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/173593002/340001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink
The CQ bit was checked by jinho.bang@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/173593002/340001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink
The CQ bit was checked by jinho.bang@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/173593002/340001
Message was sent while issue was closed.
Change committed as 168929 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
