Issue 173593: Poke a hole in the Sandbox for sending signals to self.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173593: Poke a hole in the Sandbox for sending signals to self. (Closed)

Created:
11 years, 3 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Poke a hole in the Sandbox for sending signals to self. Solves some very nasty behavior when renderers crash in a certain situation. BUG=20370 TEST=Follow repro steps for crash in 20366, browser process should show sad tabs rather than crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24674

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/renderer/renderer.sb	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

…forgot something. http://codereview.chromium.org/173593/diff/1/2 File chrome/renderer/renderer.sb (right): http://codereview.chromium.org/173593/diff/1/2#newcode10 Line 10: (allow %signal-self) That's the only line ...

11 years, 3 months ago (2009-08-27 22:05:31 UTC) #2

Nico

11 years, 3 months ago (2009-08-27 22:06:02 UTC) #3

LG. Nice analysis at crbug.com/20370 ! I couldn't find documentation on "allow
signal-self", but the change makes sense to me. I guess that's good enough :-P

I wonder what more lurks in that sandbox pit.

(thought I already sent this part)

Expand Messages | Collapse Messages