Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 173593: Poke a hole in the Sandbox for sending signals to self. (Closed)

Created:
11 years, 3 months ago by jeremy
Modified:
9 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Poke a hole in the Sandbox for sending signals to self. Solves some very nasty behavior when renderers crash in a certain situation. BUG=20370 TEST=Follow repro steps for crash in 20366, browser process should show sad tabs rather than crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24674

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/renderer/renderer.sb View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
jeremy
11 years, 3 months ago (2009-08-27 21:58:44 UTC) #1
Nico
…forgot something. http://codereview.chromium.org/173593/diff/1/2 File chrome/renderer/renderer.sb (right): http://codereview.chromium.org/173593/diff/1/2#newcode10 Line 10: (allow %signal-self) That's the only line ...
11 years, 3 months ago (2009-08-27 22:05:31 UTC) #2
Nico
11 years, 3 months ago (2009-08-27 22:06:02 UTC) #3
LG. Nice analysis at crbug.com/20370 ! I couldn't find documentation on "allow
signal-self", but the change makes sense to me. I guess that's good enough :-P

I wonder what more lurks in that sandbox pit.

(thought I already sent this part)

Powered by Google App Engine
This is Rietveld 408576698