Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: test/cflags/gyptest-cflags.py

Issue 17359002: Linux: make ninja respect environment: (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cflags/gyptest-cflags.py
===================================================================
--- test/cflags/gyptest-cflags.py (revision 1690)
+++ test/cflags/gyptest-cflags.py (working copy)
@@ -10,6 +10,7 @@
"""
import os
+import sys
import TestGyp
env_stack = []
@@ -22,10 +23,13 @@
def PopEnv():
os.eniron=env_stack.pop()
-# Regenerating build files when a gyp file changes is currently only supported
-# by the make generator.
-test = TestGyp.TestGyp(formats=['make'])
+formats = ['make']
+if sys.platform.startswith('linux'):
+ # Only Linux ninja generator supports CFLAGS.
+ formats.append('ninja')
+test = TestGyp.TestGyp(formats=formats)
+
try:
PushEnv()
os.environ['CFLAGS'] = '-O0'
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698