[ic] Unify undetectable abstract equality comparison.

[ic] Unify undetectable abstract equality comparison.

The treatment of different undetectable objects was inconsistent after
the latest changes to the undetectable bit in the maps. Given two
different undetectable JSObjects a and b, a monomorphic CompareIC would
say false for a == b, while the rest of the system (including the
generic case for the CompareIC) would say true.

The fix is rather straight-forward: We just go generic on a CompareIC
once we see an undetectable JSObject.

R=yangguo@chromium.org

Committed: https://crrev.com/1b821f2f39163d9d9a9c0f93f274cba75183bfd6
Cr-Commit-Position: refs/heads/master@{#34315}

[Benedikt Meurer, 2016-02-26 06:00:08]

Hey Yang,

This unifies the handling of undetectable JSObject comparisons (the CompareIC
was the outlier), and burns another item on the ignition failure list.
Please take a look.

Thanks,
Benedikt

Ross: FYI

[Yang, 2016-02-26 06:14:44]

On 2016/02/26 06:00:08, Benedikt Meurer wrote:
> Hey Yang,
> 
> This unifies the handling of undetectable JSObject comparisons (the CompareIC
> was the outlier), and burns another item on the ignition failure list.
> Please take a look.
> 
> Thanks,
> Benedikt
> 
> Ross: FYI

lgtm

[Benedikt Meurer, 2016-02-26 06:15:01]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-02-26 06:15:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1735863004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1735863004/1

[commit-bot: I haz the power, 2016-02-26 06:16:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-26 06:17:29]

Description was changed from

==========
[ic] Unify undetectable abstract equality comparison.

The treatment of different undetectable objects was inconsistent after
the latest changes to the undetectable bit in the maps. Given two
different undetectable JSObjects a and b, a monomorphic CompareIC would
say false for a == b, while the rest of the system (including the
generic case for the CompareIC) would say true.

The fix is rather straight-forward: We just go generic on a CompareIC
once we see an undetectable JSObject.

R=yangguo@chromium.org
==========

to

==========
[ic] Unify undetectable abstract equality comparison.

The treatment of different undetectable objects was inconsistent after
the latest changes to the undetectable bit in the maps. Given two
different undetectable JSObjects a and b, a monomorphic CompareIC would
say false for a == b, while the rest of the system (including the
generic case for the CompareIC) would say true.

The fix is rather straight-forward: We just go generic on a CompareIC
once we see an undetectable JSObject.

R=yangguo@chromium.org

Committed: https://crrev.com/1b821f2f39163d9d9a9c0f93f274cba75183bfd6
Cr-Commit-Position: refs/heads/master@{#34315}
==========

[commit-bot: I haz the power, 2016-02-26 06:17:30]

Patchset 1 (id:??) landed as
https://crrev.com/1b821f2f39163d9d9a9c0f93f274cba75183bfd6
Cr-Commit-Position: refs/heads/master@{#34315}