Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1735863002: Revert "Revert of Reland: No longer start up profile if there was an error fetching policy. (patchs… (Closed)

Created:
4 years, 10 months ago by Andrew T Wilson (Slow)
Modified:
4 years, 10 months ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: No longer start up profile if there was an error fetching policy. Changed UserCloudPolicyManagerChromeOS to no longer complete profile initialization if there is an error fetching policy. Instead, we shutdown the user and force a policy load the next time we try to startup that user. BUG=532317 TBR=tnagel@chromium.org Committed: https://crrev.com/041151c642ee1ce37e41cd6365b2f2fa456bb4bc Cr-Commit-Position: refs/heads/master@{#377558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -35 lines) Patch
M chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/affiliation_test_helper.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/blocking_login_browsertest.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/login_policy_test_base.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h View 2 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 9 chunks +49 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc View 3 chunks +66 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_factory_chromeos.cc View 2 chunks +27 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/policy/user_policy_test_helper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/user_policy_test_helper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/policy/test/policy_testserver.py View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/policy/core/browser/browser_policy_connector.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Andrew T Wilson (Slow)
No need to re-review this, Thiemo - it's just an un-revert. Should pass bots now ...
4 years, 10 months ago (2016-02-25 09:39:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735863002/1
4 years, 10 months ago (2016-02-25 09:40:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 11:52:35 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 11:54:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/041151c642ee1ce37e41cd6365b2f2fa456bb4bc
Cr-Commit-Position: refs/heads/master@{#377558}

Powered by Google App Engine
This is Rietveld 408576698