Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1735853002: X87: [fullcodegen] Implement control flow across do-expressions. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [fullcodegen] Implement control flow across do-expressions. port ee8108b71c7e63392ba9814d859aa06f47acf5e5 (r34246) original commit message: This implements proper handling of local control flow (i.e. break and continue) that spans the boundary of a do-expression. We can no longer determine the number of operands to be dropped from the nesting of statements alone, instead we use the new precise operand stack depth tracking. BUG= Committed: https://crrev.com/fbbe5ed147866c519e666c6cfe3f67dcbb3f64fd Cr-Commit-Position: refs/heads/master@{#34277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-25 07:57:07 UTC) #2
Michael Starzinger
LGTM. Thanks!
4 years, 10 months ago (2016-02-25 08:47:48 UTC) #3
Weiliang
lgtm
4 years, 10 months ago (2016-02-25 09:16:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735853002/1
4 years, 10 months ago (2016-02-25 09:17:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 09:40:29 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 09:41:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbbe5ed147866c519e666c6cfe3f67dcbb3f64fd
Cr-Commit-Position: refs/heads/master@{#34277}

Powered by Google App Engine
This is Rietveld 408576698