Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1735833003: Remove include only fwl.h and IWYU. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+537 lines, -252 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M xfa.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/include/foxitxfa.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/include/fwl/adapter/fwl_adapterthreadmgr.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/include/fwl/adapter/fwl_adapterwidgetmgr.h View 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/include/fwl/adapter/fwl_sdadapterimp.h View 2 chunks +4 lines, -8 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_caret.h View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_checkbox.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_datetimepicker.h View 2 chunks +9 lines, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_listbox.h View 2 chunks +8 lines, -3 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_monthcalendar.h View 2 chunks +7 lines, -2 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_picturebox.h View 2 chunks +3 lines, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_pushbutton.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_scrollbar.h View 3 chunks +5 lines, -4 lines 0 comments Download
M xfa/include/fwl/core/fwl_app.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_content.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/core/fwl_grid.h View 2 chunks +5 lines, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_note.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/include/fwl/core/fwl_panel.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/include/fwl/core/fwl_target.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/include/fwl/core/fwl_theme.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/include/fwl/core/fwl_thread.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/include/fwl/core/fwl_widgetmgr.h View 3 chunks +8 lines, -4 lines 0 comments Download
D xfa/include/fwl/fwl.h View 1 chunk +0 lines, -77 lines 0 comments Download
M xfa/include/fwl/lightwidget/app.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/include/fwl/lightwidget/barcode.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/include/fwl/lightwidget/caret.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/include/fwl/lightwidget/checkbox.h View 1 chunk +3 lines, -5 lines 0 comments Download
M xfa/include/fwl/lightwidget/datetimepicker.h View 1 chunk +3 lines, -5 lines 0 comments Download
M xfa/include/fwl/lightwidget/listbox.h View 1 chunk +3 lines, -4 lines 0 comments Download
M xfa/include/fwl/lightwidget/picturebox.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M xfa/include/fwl/lightwidget/pushbutton.h View 1 chunk +3 lines, -5 lines 0 comments Download
M xfa/include/fwl/lightwidget/scrollbar.h View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/include/fwl/lightwidget/tooltipctrl.h View 1 chunk +3 lines, -5 lines 0 comments Download
M xfa/include/fwl/theme/checkboxtp.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/include/fwl/theme/listboxtp.h View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/include/fwl/theme/monthcalendartp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/theme/pictureboxtp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/theme/pushbuttontp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/theme/scrollbartp.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fwl/theme/widgettp.h View 1 chunk +9 lines, -2 lines 0 comments Download
M xfa/include/fxfa/fxfa_objectacc.h View 2 chunks +2 lines, -5 lines 0 comments Download
M xfa/src/fgas/include/fx_datetime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_caretimp.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_checkboximp.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_listboximp.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_scrollbarimp.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_spinbuttonimp.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_tooltipctrlimp.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_barcodeimp.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_datetimepickerimp.h View 1 chunk +5 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_editimp.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_listboximp.h View 1 chunk +7 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_monthcalendarimp.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_scrollbarimp.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_spinbuttonimp.h View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_tooltipctrlimp.h View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/include/fxmath_barcodeimp.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_appimp.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M xfa/src/fwl/src/core/fwl_contentimp.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fwl/src/core/fwl_formimp.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M xfa/src/fwl/src/core/fwl_noteimp.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M xfa/src/fwl/src/core/fwl_panelimp.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M xfa/src/fwl/src/core/fwl_sdadapterimp.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_timerimp.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetimp.cpp View 1 chunk +12 lines, -1 line 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M xfa/src/fwl/src/core/include/fwl_formimp.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_gridimp.h View 1 chunk +4 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_widgetmgrimp.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/app.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/barcode.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/caret.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/checkbox.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/combobox.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/datetimepicker.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/edit.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/listbox.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/picturebox.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/pushbutton.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/scrollbar.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/theme.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/tooltipctrl.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/widget.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/barcodetp.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/carettp.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/checkboxtp.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/comboboxtp.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/datetimepickertp.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/edittp.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/formtp.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/listboxtp.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/monthcalendartp.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/pictureboxtp.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/pushbuttontp.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/scrollbartp.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/widgettp.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffapp.h View 2 chunks +14 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffapp.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffbarcode.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffbarcode.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffcheckbutton.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffchoicelist.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdoc.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fffield.h View 2 chunks +4 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fffield.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffimageedit.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffimageedit.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpushbutton.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpushbutton.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftext.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftext.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftextedit.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidget.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwltheme.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwltheme.cpp View 1 1 chunk +11 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/common/fxfa_localevalue.h View 2 chunks +4 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_document.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_localemgr.h View 3 chunks +8 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_object.h View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_utils.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_fm2jscontext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_localevalue.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_objectacc_imp.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_utils_imp.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
PTAL. Remove fwl.h it's only included once he thought. Sigh.
4 years, 10 months ago (2016-02-25 16:09:58 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1735833003/diff/1/xfa/include/fwl/lightwidget/picturebox.h File xfa/include/fwl/lightwidget/picturebox.h (right): https://codereview.chromium.org/1735833003/diff/1/xfa/include/fwl/lightwidget/picturebox.h#newcode10 xfa/include/fwl/lightwidget/picturebox.h:10: #include "xfa/include/fwl/core/fwl_error.h" alphabetical order https://codereview.chromium.org/1735833003/diff/1/xfa/src/fwl/src/basewidget/include/fwl_tooltipctrlimp.h File xfa/src/fwl/src/basewidget/include/fwl_tooltipctrlimp.h (right): ...
4 years, 10 months ago (2016-02-25 18:31:37 UTC) #3
dsinclair
https://codereview.chromium.org/1735833003/diff/1/xfa/include/fwl/lightwidget/picturebox.h File xfa/include/fwl/lightwidget/picturebox.h (right): https://codereview.chromium.org/1735833003/diff/1/xfa/include/fwl/lightwidget/picturebox.h#newcode10 xfa/include/fwl/lightwidget/picturebox.h:10: #include "xfa/include/fwl/core/fwl_error.h" On 2016/02/25 18:31:37, Lei Zhang wrote: > ...
4 years, 10 months ago (2016-02-25 18:38:14 UTC) #4
dsinclair
4 years, 10 months ago (2016-02-25 18:38:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e73c5ceb8176dfd92138780f640ac193f1c0ea30 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698