Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 1735833002: Remove WebContentsObserver::DidGetUserGesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index 6c8aded1a2b56e042940e080e4f3070f88bcdde0..29c2c1edb72ee34b82daa08c188647caf5451d82 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -317,22 +317,19 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
// failure methods will also be invoked.
virtual void NavigationStopped() {}
- // This indicates that the next navigation was triggered by a user gesture.
- // TODO(dominickn): remove this method in favor of DidGetUserInteraction,
- // with the appropriate filtering by input event type.
- virtual void DidGetUserGesture() {}
-
// Called when there has been direct user interaction with the WebContents.
// The type argument specifies the kind of interaction. Direct user input
// signalled through this callback includes:
// 1) any mouse down event (blink::WebInputEvent::MouseDown);
// 2) the start of a mouse wheel scroll (blink::WebInputEvent::MouseWheel);
- // 3) any raw key down event (blink::WebInputEvent::RawKeyDown); and
- // 4) any gesture tap event (blink::WebInputEvent::GestureTapDown).
+ // 3) any raw key down event (blink::WebInputEvent::RawKeyDown);
+ // 4) any gesture tap event (blink::WebInputEvent::GestureTapDown); and
+ // 5) a browser navigation or reload (blink::WebInputEvent::Undefined).
// The start of a mouse wheel scroll is heuristically detected: a mouse
// wheel event fired at least 0.1 seconds after any other wheel event is
// regarded as the beginning of a scroll. This matches the interval used by
// the Blink EventHandler to detect the end of scrolls.
+ // TODO(dominickn): replace MouseWheel with GestureScrollBegin.
virtual void DidGetUserInteraction(const blink::WebInputEvent::Type type) {}
// This method is invoked when a RenderViewHost of this WebContents was
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698