chrome/browser/ui/browser_browsertest.cc - Issue 1735833002: Remove WebContentsObserver::DidGetUserGesture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 1735833002: Remove WebContentsObserver::DidGetUserGesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_browsertest.cc

diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc

index da10776145b10134468bb4c775a326e095870822..fde2e611c07fc14fc312c50de89965bb47b59548 100644

--- a/chrome/browser/ui/browser_browsertest.cc

+++ b/chrome/browser/ui/browser_browsertest.cc

@@ -2099,7 +2099,9 @@ class MockWebContentsObserver : public WebContentsObserver {

got_user_gesture_(false) {

}

- void DidGetUserGesture() override { got_user_gesture_ = true; }

+ void DidGetUserInteraction(const blink::WebInputEvent::Type type) override {

tdresser 2016/02/25 14:42:48 Can we add a test that the type here is sane?

dominickn 2016/02/26 00:36:11 Done.

+ got_user_gesture_ = true;

+ }

bool got_user_gesture() const {

return got_user_gesture_;