third_party/WebKit/LayoutTests/media/avtrack/video-track-properties.html - Issue 1735803002: Implemented passing media track info from ffmpeg into blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/avtrack/video-track-properties.html

Issue 1735803002: Implemented passing media track info from ffmpeg into blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cast_shell + test nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/avtrack/audio-track-properties.html ('K') | « third_party/WebKit/LayoutTests/media/avtrack/audio-track-properties.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>VideoTrack properties read from input stream metadata</title>

	5 <script src="../../resources/testharness.js"></script>

	6 <script src="../../resources/testharnessreport.js"></script>

	7 <script src="../media-file.js"></script>

	8 </head>

	9 <body>

	10 <div id="log"></div>

	11 <script>

	12 async_test(function(t)

	13 {

	14 var e = document.createElement("video");

	15 e.src = "../content/test.mp4";

	16

	17 e.onloadedmetadata = t.step_func_done(function()

	18 {

	19 assert_equals(e.videoTracks.length, 1, "videoTracks.length") ;

	20 assert_true(e.videoTracks[0].selected, "videoTrack.selected" );

	21 assert_equals(e.videoTracks[0].kind, "main", "videoTrack.kin d");

	22 assert_equals(e.videoTracks[0].label, "", "videoTrack.label" );

	23 assert_equals(e.videoTracks[0].language, "eng", "videoTrack. language");
	philipj_slow 2016/02/26 11:42:56 This seems even more strange. What does it mean fo This seems even more strange. What does it mean for a video track to be in English? servolk 2016/02/27 00:56:21 See my other comment. Per https://dev.w3.org/html5 Show quoted text On 2016/02/26 11:42:56, philipj_UTC7 wrote: > This seems even more strange. What does it mean for a video track to be in > English? See my other comment. Per https://dev.w3.org/html5/html-sourcing-inband-tracks/#mpeg4 spec both audio and video tracks have the language property. And here the video track is marked as 'eng' as well.
	24 });

	25 });

	26 </script>

	27 </body>

	28 </html>

OLD	NEW