third_party/WebKit/LayoutTests/media/avtrack/audio-track-properties.html - Issue 1735803002: Implemented passing media track info from ffmpeg into blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/avtrack/audio-track-properties.html

Issue 1735803002: Implemented passing media track info from ffmpeg into blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed cast_shell + test nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « media/test/pipeline_integration_test_base.cc ('k') | third_party/WebKit/LayoutTests/media/avtrack/video-track-properties.html » ('j') | third_party/WebKit/LayoutTests/media/avtrack/video-track-properties.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>AudioTrack properties read from input stream metadata</title>

	5 <script src="../../resources/testharness.js"></script>

	6 <script src="../../resources/testharnessreport.js"></script>

	7 <script src="../media-file.js"></script>

	8 </head>

	9 <body>

	10 <div id="log"></div>

	11 <script>

	12 async_test(function(t)

	13 {

	14 var e = document.createElement("audio");

	15 e.src = "../content/test.mp4";

	16

	17 e.onloadedmetadata = t.step_func_done(function()

	18 {

	19 assert_equals(e.audioTracks.length, 1, "audioTracks.length") ;

	20 assert_true(e.audioTracks[0].enabled, "audioTrack.enabled");

	21 assert_equals(e.audioTracks[0].kind, "main", "audioTrack.kin d");

	22 assert_equals(e.audioTracks[0].label, "", "audioTrack.label" );

	23 assert_equals(e.audioTracks[0].language, "eng", "audioTrack. language");
	philipj_slow 2016/02/26 11:42:56 Does test.mp4 actually have an audio track marked Does test.mp4 actually have an audio track marked up as English, and if so why? Also, why is it "eng" and not "en"? servolk 2016/02/27 00:56:21 I'm not sure how the test.mp4 was generated, but y Show quoted text On 2016/02/26 11:42:56, philipj_UTC7 wrote: > Does test.mp4 actually have an audio track marked up as English, and if so why? > Also, why is it "eng" and not "en"? I'm not sure how the test.mp4 was generated, but yes, it does actually have an audio track marked "eng". I've been working on better sourcing of media track data from for all media track fields. As wolenetz@ said the spec for that is: https://dev.w3.org/html5/html-sourcing-inband-tracks/#mpeg4 For this particular test.mp4 file the value of the language_code field in MediaHeaderBox translates to "eng". To clarify: I've first implemented better track info sourcing in our internal mp4/webm parsers in a separate CL for MSE (https://codereview.chromium.org/1735003004/), and then I did the same for ffmpeg demuxer which provides all the same metadata that is available directly to us in our internal mp4 parser. Note that in the MSE CL for a test file generated by a different tool the values of track.label and track.language are different, the language is "und" (i.e. undefined) there.
	24 });

	25 });

	26 </script>

	27 </body>

	28 </html>

OLD	NEW