third_party/WebKit/LayoutTests/media/avtrack/audio-track-properties.html - Issue 1735803002: Implemented passing media track info from ffmpeg into blink

Side by Side Diff: third_party/WebKit/LayoutTests/media/avtrack/audio-track-properties.html

Issue 1735803002: Implemented passing media track info from ffmpeg into blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « media/test/pipeline_integration_test_base.cc ('k') | third_party/WebKit/LayoutTests/media/avtrack/video-track-properties.html » ('j') | third_party/WebKit/LayoutTests/media/avtrack/video-track-properties.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>AudioTrack properties read from input stream metadata</title>

	5 <script src="../../resources/testharness.js"></script>

	6 <script src="../../resources/testharnessreport.js"></script>

	7 <script src="../media-file.js"></script>

	8 </head>

	9 <body>

	10 <div id="log"></div>
	fs 2016/02/25 11:40:39 You shouldn't need this. Ditto for <html>, <head> You shouldn't need this. Ditto for <html>, <head> and <body>. servolk 2016/02/25 18:14:23 Are you sure? For some reason all other HTML files Show quoted text On 2016/02/25 11:40:39, fs wrote: > You shouldn't need this. Ditto for <html>, <head> and <body>. Are you sure? For some reason all other HTML files in this folder have them, so I'd prefer to keep those too, for consistency with other tests. If we decide to remove all these extra tags, then we can do this later for all tests at once in a separate CL. fs 2016/02/25 18:36:40 I don't care greatly, but personally I think it's Show quoted text On 2016/02/25 at 18:14:23, servolk wrote: > On 2016/02/25 11:40:39, fs wrote: > > You shouldn't need this. Ditto for <html>, <head> and <body>. > > Are you sure? For some reason all other HTML files in this folder have them, so I'd prefer to keep those too, for consistency with other tests. If we decide to remove all these extra tags, then we can do this later for all tests at once in a separate CL. I don't care greatly, but personally I think it's better to try to write new tests per existing guidelines/style [1] rather than maintaining some old style artifact. But personally I find this test (and all the other tests in this directory) to be way too deeply indented too so... =) [1] http://dev.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-h... philipj_slow 2016/02/26 11:42:56 FWIW, I always go with minimal markup and minimal Show quoted text On 2016/02/25 18:36:40, fs wrote: > On 2016/02/25 at 18:14:23, servolk wrote: > > On 2016/02/25 11:40:39, fs wrote: > > > You shouldn't need this. Ditto for <html>, <head> and <body>. > > > > Are you sure? For some reason all other HTML files in this folder have them, > so I'd prefer to keep those too, for consistency with other tests. If we decide > to remove all these extra tags, then we can do this later for all tests at once > in a separate CL. > > I don't care greatly, but personally I think it's better to try to write new > tests per existing guidelines/style [1] rather than maintaining some old style > artifact. But personally I find this test (and all the other tests in this > directory) to be way too deeply indented too so... =) > > [1] > http://dev.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-h... FWIW, I always go with minimal markup and minimal indentation (basically only indent inside script) when writing new testharness.js tests.
	11 <script>

	12 async_test(function(t)

	13 {

	14 var e = document.createElement("audio");

	15 e.src = "../content/test.mp4";

	16

	17 e.onloadedmetadata = t.step_func(function()
	fs 2016/02/25 11:40:39 I think you could use step_func_done here and ditc I think you could use step_func_done here and ditch the explicit done. servolk 2016/02/25 18:14:23 Done. Show quoted text On 2016/02/25 11:40:39, fs wrote: > I think you could use step_func_done here and ditch the explicit done. Done.
	18 {

	19 assert_equals(e.audioTracks.length, 1, "audioTracks.length") ;

	20 assert_true(e.audioTracks[0].enabled, "audioTrack.enabled");

	21 assert_equals(e.audioTracks[0].kind, "main", "audioTrack.kin d");

	22 assert_equals(e.audioTracks[0].label, "", "audioTrack.label" );

	23 assert_equals(e.audioTracks[0].language, "eng", "audioTrack. language");

	24 t.done();

	25 });

	26 }, "AudioTrack properties read from input stream metadata");
	fs 2016/02/25 11:40:39 This will be picked up from the <title>. This will be picked up from the <title>. servolk 2016/02/25 18:14:23 Done. Show quoted text On 2016/02/25 11:40:39, fs wrote: > This will be picked up from the <title>. Done.
	27 </script>

	28 </body>

	29 </html>

OLD	NEW