Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 1735763002: Pass ffmpeg media track info to HTMLMediaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@demuxer-tracks
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/avtrack/audio-track-properties.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index 071e70ea84795f1ee587582696245009946f7175..dc42a3d23d396df755ac8ea0160132c1ac240ee0 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -191,6 +191,7 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
suppress_destruction_errors_(false) {
DCHECK(!adjust_allocated_memory_cb_.is_null());
DCHECK(renderer_factory_);
+ DCHECK(client_);
if (delegate_)
delegate_id_ = delegate_->AddObserver(this);
@@ -803,6 +804,30 @@ void WebMediaPlayerImpl::OnFFmpegMediaTracksUpdated(
// WebSourceBufferImpl.
DCHECK(demuxer_.get());
DCHECK(!chunk_demuxer_);
+
+ // Report the media track information to blink.
+ for (const auto& track : tracks->tracks()) {
+ if (track->type() == MediaTrack::Audio) {
+ auto track_id = client_->addAudioTrack(
+ blink::WebString::fromUTF8(track->id()),
+ blink::WebMediaPlayerClient::AudioTrackKindMain,
+ blink::WebString::fromUTF8(track->label()),
+ blink::WebString::fromUTF8(track->language()),
+ /*enabled*/ true);
+ (void)track_id;
+ } else if (track->type() == MediaTrack::Video) {
+ auto track_id = client_->addVideoTrack(
+ blink::WebString::fromUTF8(track->id()),
+ blink::WebMediaPlayerClient::VideoTrackKindMain,
+ blink::WebString::fromUTF8(track->label()),
+ blink::WebString::fromUTF8(track->language()),
+ /*selected*/ true);
+ (void)track_id;
+ } else {
+ // Text tracks are not supported through this code path yet.
+ NOTREACHED();
+ }
+ }
}
void WebMediaPlayerImpl::OnWaitingForDecryptionKey() {
@@ -1209,8 +1234,7 @@ void WebMediaPlayerImpl::StartPipeline() {
#if !defined(MEDIA_DISABLE_FFMPEG)
Demuxer::MediaTracksUpdatedCB media_tracks_updated_cb =
- base::Bind(&WebMediaPlayerImpl::OnFFmpegMediaTracksUpdated,
- base::Unretained(this));
+ BIND_TO_RENDER_LOOP(&WebMediaPlayerImpl::OnFFmpegMediaTracksUpdated);
demuxer_.reset(new FFmpegDemuxer(media_task_runner_, data_source_.get(),
encrypted_media_init_data_cb,
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/avtrack/audio-track-properties.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698