Pass ffmpeg media track info to HTMLMediaElement

media/blink/webmediaplayer_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
 #define MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 442 matching lines @@
   // for a transient sound.  Playout volume is derived by volume * multiplier.
   double volume_;
   double volume_multiplier_;
 
   scoped_ptr<RendererFactory> renderer_factory_;
 
   // For requesting surfaces on behalf of the Android H/W decoder in fullscreen.
   // This will be null everywhere but Android.
   SurfaceManager* surface_manager_;
 
+  std::vector<blink::WebMediaPlayer::TrackId> blink_audio_tracks_;

[wolenetz, 2016/03/11 23:19:54]

nit: do we really need the "blink_" prefix on these members? If that prefix were
removed, would there be some confusion or name conflict introduced? I suggest
s/blink_audio_tracks_/audio_track_ids/ (and similar for video).

[servolk, 2016/03/18 18:36:42]

The main reason I wanted to include 'blink_' in here is to avoid confusion about
whether these are bytestream track ids or blink track ids (which are
different!). I guess it's already clear here, since we have 'blink::' in the
type definition, but I wanted this to be also clear in the code where these
collections are used (e.g. in WMPI::OnFFmpegMediaTracksUpdated).
But now that we are going to assume FFmpeg tracks are only going to be reported
once (see the other comment), we can just remove these collections altogether.

[wolenetz, 2016/03/23 22:53:03]

Acknowledged.

+  std::vector<blink::WebMediaPlayer::TrackId> blink_video_tracks_;
+
   DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_