Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1735743003: Add a DM flag to limit the types of Codec decodes (Closed)

Created:
4 years, 9 months ago by scroggo_chromium
Modified:
4 years, 9 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a DM flag to limit the types of Codec decodes When the flag "simpleCodec" is set to true, we will only decode to the canvas colortype and to a scale of 1. No SkAndroidCodec or BRDCodec tests are run. This makes it easier to find the simple case when running locally. Clean up some SkImageDecoder references along the way. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1735743003 Committed: https://skia.googlesource.com/skia/+/e4499849df904c30c21e0eacaf11b9e9a985313f

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M dm/DM.cpp View 6 chunks +15 lines, -4 lines 2 comments Download

Messages

Total messages: 8 (4 generated)
scroggo
https://codereview.chromium.org/1735743003/diff/1/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/1735743003/diff/1/dm/DM.cpp#newcode67 dm/DM.cpp:67: DEFINE_bool(simpleCodec, false, "Only decode images to native scale"); Alternatively, ...
4 years, 9 months ago (2016-02-25 17:08:36 UTC) #3
msarett
lgtm This is great. Don't want to think about how time I've spent commenting out ...
4 years, 9 months ago (2016-02-25 17:47:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735743003/1
4 years, 9 months ago (2016-02-25 18:47:50 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-25 19:03:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e4499849df904c30c21e0eacaf11b9e9a985313f

Powered by Google App Engine
This is Rietveld 408576698