Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1735743002: Use the MonitorFromPoint API for the cursor position to cover cases where the MonitorFromWindow API… (Closed)

Created:
4 years, 10 months ago by ananta
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the MonitorFromPoint API for the cursor position to cover cases where the MonitorFromWindow API fails. In some cases the MonitorFromWindow API for the taskbar fails to return the correct monitor. Examples include the autohide taskbar on the left of the secondary monitor or the right of the primary monitor. This causes maximized Chrome windows to draw over these taskbars. Fix is to use the MonitorFromPoint API for the cursor position which seems to work for these cases. BUG=472139 Committed: https://crrev.com/a25bf4f5f135fa548f7a2de0580059313c6730b9 Cr-Commit-Position: refs/heads/master@{#377661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +15 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
ananta
4 years, 10 months ago (2016-02-24 22:13:34 UTC) #2
sky
LGTM
4 years, 10 months ago (2016-02-25 00:41:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735743002/1
4 years, 10 months ago (2016-02-25 20:20:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 20:38:23 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 20:39:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a25bf4f5f135fa548f7a2de0580059313c6730b9
Cr-Commit-Position: refs/heads/master@{#377661}

Powered by Google App Engine
This is Rietveld 408576698