Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1598)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/cctest.status

Issue 1735733002: Fix iterator (std::vector) invalidation during sampling heap profile retrieval (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix windows build (signed/unsigned compare) Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/profiler/sampling-heap-profiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index 5acd1b8b0fc31fdf1363ec9a91eb9cbeb5c6d729..8eaa9515b1b840e82244d3dec9521872f0e7568d 100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -613,9 +613,6 @@
# TODO(rmcilroy,4680): Test assert errors.
'test-heap-profiler/HeapSnapshotSimd': [PASS, ['mode == debug', FAIL]],
'test-api/InitializeDefaultIsolateOnSecondaryThread1': [PASS, ['mode == debug', FAIL]],
-
- # TODO(rmcilroy,mattloring).
- 'test-heap-profiler/SamplingHeapProfiler': [PASS, ['mode == debug', SKIP]],
}],
]
« no previous file with comments | « src/profiler/sampling-heap-profiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698