test/cctest/wasm/test-run-wasm.cc - Issue 1735673003: [wasm] mips: Turn off signalling NaN tests on mips and mips64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/wasm/test-run-wasm.cc

Issue 1735673003: [wasm] mips: Turn off signalling NaN tests on mips and mips64. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/wasm/test-run-wasm.cc

diff --git a/test/cctest/wasm/test-run-wasm.cc b/test/cctest/wasm/test-run-wasm.cc

index 3b468b5de670342864a4be5898c95f10cf9a7c29..91252277a1c565b2933e9b728989da6a0d9e8699 100644

--- a/test/cctest/wasm/test-run-wasm.cc

+++ b/test/cctest/wasm/test-run-wasm.cc

@@ -3097,8 +3097,9 @@ TEST(Run_Wasm_F64Max) {

}

-// TODO(ahaas): Fix on arm and reenable.

-#if !V8_TARGET_ARCH_ARM && !V8_TARGET_ARCH_ARM64

+// TODO(ahaas): Fix on arm and mips and reenable.

+#if !V8_TARGET_ARCH_ARM && !V8_TARGET_ARCH_ARM64 && !V8_TARGET_ARCH_MIPS && \

+ !V8_TARGET_ARCH_MIPS64

TEST(Run_Wasm_F32Min_Snan) {

// Test that the instruction does not return a signalling NaN.

« no previous file with comments | « src/mips/simulator-mips.cc ('k') | no next file » | no next file with comments »