Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1735673003: [wasm] mips: Turn off signalling NaN tests on mips and mips64. (Closed)

Created:
4 years, 10 months ago by ahaas
Modified:
4 years, 10 months ago
Reviewers:
titzer, Michael Starzinger, v8-mips-ports
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] mips: Turn off signalling NaN tests on mips and mips64. I turn the test off for now. The problem is that mips does not deal with signalling NaNs as expected. @v8-mips-ports: Could it be that the mips simulator deals differently with signalling NaNs than the actual hardware? The implementation that is tested in these tests assumes that sNaN * 1.0 = qNaN, where the bits of sNaN and qNaN are equal except for the most significant mantissa bit. This assumption holds for the simulator, but seems not to hold for actual mips hardware. Do you know more about that? R=mstarzinger@chromium.org, titzer@chromium.org, v8-mips-ports@googlegroups.com Committed: https://crrev.com/5dc96ae28dc2bcf467057e722394438b2388bc8f Cr-Commit-Position: refs/heads/master@{#34278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/mips/simulator-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ahaas
4 years, 10 months ago (2016-02-25 09:29:26 UTC) #1
Michael Starzinger
LGTM. Thanks!
4 years, 10 months ago (2016-02-25 09:39:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735673003/1
4 years, 10 months ago (2016-02-25 09:43:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 09:50:03 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 09:50:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dc96ae28dc2bcf467057e722394438b2388bc8f
Cr-Commit-Position: refs/heads/master@{#34278}

Powered by Google App Engine
This is Rietveld 408576698