Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 173563002: drive: Remove FileCacheTestOnUIThread (Closed)

Created:
6 years, 10 months ago by hashimoto
Modified:
6 years, 10 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

drive: Remove FileCacheTestOnUIThread Add tests for Store, PinAndUnpin, MountUnmount, Remove. BUG=229822 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252326

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -492 lines) Patch
M chrome/browser/chromeos/drive/file_cache.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 4 chunks +134 lines, -491 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
6 years, 10 months ago (2014-02-20 08:49:07 UTC) #1
kinaba
lgtm
6 years, 10 months ago (2014-02-20 09:02:11 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 10 months ago (2014-02-20 11:09:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/173563002/80001
6 years, 10 months ago (2014-02-20 12:47:43 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 18:34:47 UTC) #5
Message was sent while issue was closed.
Change committed as 252326

Powered by Google App Engine
This is Rietveld 408576698