Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1735623002: PPC: [fullcodegen] Implement control flow across do-expressions. (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [fullcodegen] Implement control flow across do-expressions. Port ee8108b71c7e63392ba9814d859aa06f47acf5e5 Original commit message: This implements proper handling of local control flow (i.e. break and continue) that spans the boundary of a do-expression. We can no longer determine the number of operands to be dropped from the nesting of statements alone, instead we use the new precise operand stack depth tracking. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com TEST=mjsunit/harmony/do-expressions-control BUG=v8:4488 LOG=n Committed: https://crrev.com/54d6d35a07cd772859a0c677d7afeba9430879fc Cr-Commit-Position: refs/heads/master@{#34264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
4 years, 10 months ago (2016-02-24 18:44:22 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735623002/1
4 years, 10 months ago (2016-02-24 18:56:47 UTC) #3
Michael Starzinger
LGTM. Thanks!
4 years, 10 months ago (2016-02-24 19:08:04 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 19:17:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735623002/1
4 years, 10 months ago (2016-02-24 19:19:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 19:21:21 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 19:21:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54d6d35a07cd772859a0c677d7afeba9430879fc
Cr-Commit-Position: refs/heads/master@{#34264}

Powered by Google App Engine
This is Rietveld 408576698