Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 17356006: Files.app: Stop using DragSelector on the grid view. (Closed)

Created:
7 years, 6 months ago by hirono
Modified:
7 years, 6 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Stop using DragSelector on the grid view. Currently DragSelector does not support grid view, but it is used at the onDragStart_ method. This CL added a condition to the if statement in order to stop using DragSelector on the grid view. BUG=252150 TEST=manually R=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207774

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/file_manager/js/file_transfer_controller.js View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
hirono
Could you check the CL? Thank you very much!
7 years, 6 months ago (2013-06-21 02:59:59 UTC) #1
mtomasz
lgtm for a temporary solution https://codereview.chromium.org/17356006/diff/1/chrome/browser/resources/file_manager/js/file_transfer_controller.js File chrome/browser/resources/file_manager/js/file_transfer_controller.js (right): https://codereview.chromium.org/17356006/diff/1/chrome/browser/resources/file_manager/js/file_transfer_controller.js#newcode293 chrome/browser/resources/file_manager/js/file_transfer_controller.js:293: if (list.id == 'file-list' ...
7 years, 6 months ago (2013-06-21 06:20:58 UTC) #2
hirono
On 2013/06/21 06:20:58, mtomasz wrote: > lgtm for a temporary solution > > https://codereview.chromium.org/17356006/diff/1/chrome/browser/resources/file_manager/js/file_transfer_controller.js > ...
7 years, 6 months ago (2013-06-21 06:25:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/17356006/1
7 years, 6 months ago (2013-06-21 06:25:59 UTC) #4
hirono
7 years, 6 months ago (2013-06-21 09:52:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r207774 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698