Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1891)

Issue 1735583002: Rename WeakBindingSet/WeakInterfacePtrSet to BindingSet/InterfacePtrSet. (Closed)

Created:
4 years, 10 months ago by yzshen1
Modified:
4 years, 10 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, sadrul, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename WeakBindingSet/WeakInterfacePtrSet to BindingSet/InterfacePtrSet. This CL also renames the element type (WeakBinding/WeakInterfacePtr) to Element and hide them in the corresonding *Set class. BUG=None CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/632d319842096e6998d174e2f251865979ce2b72 Cr-Commit-Position: refs/heads/master@{#377384} Committed: https://crrev.com/d414dc34a7f87a2000e09c58b9ddbb5bd6b61463 Cr-Commit-Position: refs/heads/master@{#377528}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -297 lines) Patch
M chrome/app/mash/mash_runner.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_interface_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/usb/web_usb_permission_bubble.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/usb/web_usb_permission_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/font_service/font_service_app.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_app.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/mus_app.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/connection_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/ws/window_tree_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/resource_provider/resource_provider_app.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/frame_mojo_shell.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/level_db_wrapper_impl.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/storage_partition_impl.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/vr/vr_device_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/mus/render_widget_window_tree_client_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/utility/utility_thread_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/usb/mojo/fake_permission_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/screenlock/screenlock.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mash/shell/shell_application_delegate.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M mash/wm/accelerator_registrar_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager_application.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/mojo_public.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A mojo/public/cpp/bindings/binding_set.h View 1 chunk +113 lines, -0 lines 0 comments Download
A mojo/public/cpp/bindings/interface_ptr_set.h View 1 chunk +83 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/pickle_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_traits_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D mojo/public/cpp/bindings/weak_binding_set.h View 1 chunk +0 lines, -118 lines 0 comments Download
D mojo/public/cpp/bindings/weak_interface_ptr_set.h View 1 chunk +0 lines, -88 lines 0 comments Download
M mojo/services/package_manager/package_manager.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/tracing/tracing_app.h View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/application_instance.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/application_manager.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/background/tests/test_service.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/runner/child/native_apptest_target.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/tests/application_manager_apptest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/tests/application_manager_apptest_driver.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/tests/capability_filter_test.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/tests/package_test_package.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
yzshen1
Hi, Ben. Would you please take a look? Thanks!
4 years, 10 months ago (2016-02-24 17:40:21 UTC) #3
Ben Goodger (Google)
lgtm, yay!
4 years, 10 months ago (2016-02-24 17:56:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735583002/20001
4 years, 10 months ago (2016-02-24 18:36:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/148098)
4 years, 10 months ago (2016-02-24 19:14:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735583002/40001
4 years, 10 months ago (2016-02-24 19:27:37 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-24 21:20:46 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/632d319842096e6998d174e2f251865979ce2b72 Cr-Commit-Position: refs/heads/master@{#377384}
4 years, 10 months ago (2016-02-24 21:21:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735583002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735583002/60001
4 years, 10 months ago (2016-02-25 06:14:45 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-25 07:29:35 UTC) #21
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 07:30:29 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d414dc34a7f87a2000e09c58b9ddbb5bd6b61463
Cr-Commit-Position: refs/heads/master@{#377528}

Powered by Google App Engine
This is Rietveld 408576698