Issue 1735523006: Readd the C++ ABI alignment handling logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1735523006: Readd the C++ ABI alignment handling logic (Closed)

Created:
4 years, 10 months ago by Petr Hosek

Modified:
4 years, 10 months ago

Reviewers:
Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/a/native_client/pnacl-clang.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Readd the C++ ABI alignment handling logic This code was accidentally removed during Emscripten support removal. R=stichnot@chromium.org Committed: 25d3d1fa3f49cabead2807f6d5e7e2a2127fa2c7

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	include/clang/Basic/TargetCXXABI.h	View		1 chunk	+18 lines, -0 lines	0 comments	Download
	M	lib/CodeGen/CodeGenModule.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Petr Hosek

4 years, 10 months ago (2016-02-26 02:15:37 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
25d3d1fa3f49cabead2807f6d5e7e2a2127fa2c7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages