Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1735353002: Remove fde.h and IWYU. (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Actually delete fde.h #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -34 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M xfa.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
D xfa/src/fdp/include/fde.h View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
M xfa/src/fdp/include/fde_brs.h View 7 chunks +12 lines, -5 lines 0 comments Download
M xfa/src/fdp/src/css/fde_csscache.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fdp/src/css/fde_cssdeclaration.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fdp/src/css/fde_cssstylesheet.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtengine.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M xfa/src/foxitlib.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_checkboximp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_listboximp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_tooltipctrlimp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_formimp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetimp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/widget.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/checkboxtp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/formtp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/monthcalendartp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fwl/src/theme/widgettp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpageview.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwltheme.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_textlayout.h View 9 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dsinclair
PTAL.
4 years, 10 months ago (2016-02-25 20:07:53 UTC) #2
Lei Zhang
I don't see fde.h being deleted.
4 years, 10 months ago (2016-02-25 20:13:28 UTC) #3
Lei Zhang
Otherwise lgtm
4 years, 10 months ago (2016-02-25 20:14:42 UTC) #4
dsinclair
4 years, 10 months ago (2016-02-25 20:16:47 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
3a479763796edeb8cf5acc8735a16878ad6bfeb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698