Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: tools/push-to-trunk/push_to_trunk.py

Issue 173533002: Fix options in push-to-trunk script. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 the V8 project authors. All rights reserved. 2 # Copyright 2013 the V8 project authors. All rights reserved.
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following 10 # copyright notice, this list of conditions and the following
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 """Convenience wrapper.""" 61 """Convenience wrapper."""
62 class Options(object): 62 class Options(object):
63 pass 63 pass
64 options = Options() 64 options = Options()
65 options.s = 0 65 options.s = 0
66 options.l = None 66 options.l = None
67 options.b = None 67 options.b = None
68 options.f = True 68 options.f = True
69 options.m = False 69 options.m = False
70 options.c = chrome_path 70 options.c = chrome_path
71 options.reviewer = reviewer
71 options.a = author 72 options.a = author
72 return PushToTrunkOptions(options) 73 return PushToTrunkOptions(options)
73 74
74 def __init__(self, options): 75 def __init__(self, options):
75 super(PushToTrunkOptions, self).__init__(options, options.m) 76 super(PushToTrunkOptions, self).__init__(options, options.m)
76 self.requires_editor = not options.f 77 self.requires_editor = not options.f
77 self.wait_for_lgtm = not options.f 78 self.wait_for_lgtm = not options.f
78 self.tbr_commit = not options.m 79 self.tbr_commit = not options.m
79 self.l = options.l 80 self.l = options.l
80 self.reviewer = options.reviewer 81 self.reviewer = options.reviewer
81 self.c = options.c 82 self.c = options.c
82 self.b = getattr(options, 'b', None) 83 self.b = getattr(options, 'b', None)
83 self.author = getattr(options, 'a', None) 84 self.author = getattr(options, 'a', None)
84 85
86
85 class Preparation(Step): 87 class Preparation(Step):
86 MESSAGE = "Preparation." 88 MESSAGE = "Preparation."
87 89
88 def RunStep(self): 90 def RunStep(self):
89 self.InitialEnvironmentChecks() 91 self.InitialEnvironmentChecks()
90 self.CommonPrepare() 92 self.CommonPrepare()
91 self.PrepareBranch() 93 self.PrepareBranch()
92 self.DeleteBranch(self.Config(TRUNKBRANCH)) 94 self.DeleteBranch(self.Config(TRUNKBRANCH))
93 95
94 96
(...skipping 508 matching lines...) Expand 10 before | Expand all | Expand 10 after
603 def Main(): 605 def Main():
604 parser = BuildOptions() 606 parser = BuildOptions()
605 (options, args) = parser.parse_args() 607 (options, args) = parser.parse_args()
606 if not ProcessOptions(options): 608 if not ProcessOptions(options):
607 parser.print_help() 609 parser.print_help()
608 return 1 610 return 1
609 RunPushToTrunk(CONFIG, PushToTrunkOptions(options)) 611 RunPushToTrunk(CONFIG, PushToTrunkOptions(options))
610 612
611 if __name__ == "__main__": 613 if __name__ == "__main__":
612 sys.exit(Main()) 614 sys.exit(Main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698