Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1735313004: [DevTools] Do not delegate menu list rendering in LayoutThemeMobile. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not delegate menu list rendering in LayoutThemeMobile. It makes sense only on android, while emulating mobile device should still render the menu list. BUG=590134 Committed: https://crrev.com/8144508edcd0c0c221e355ee09e3394f6d79d2d5 Cr-Commit-Position: refs/heads/master@{#377979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutThemeAndroid.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMobile.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 9 months ago (2016-02-26 18:11:14 UTC) #2
pfeldman
lgtm
4 years, 9 months ago (2016-02-26 18:22:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735313004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735313004/1
4 years, 9 months ago (2016-02-26 18:25:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-26 21:24:09 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 21:24:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8144508edcd0c0c221e355ee09e3394f6d79d2d5
Cr-Commit-Position: refs/heads/master@{#377979}

Powered by Google App Engine
This is Rietveld 408576698