Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1735313002: Skip pkg tests in Dart product/precompiled modes as the test framework uses (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip pkg tests in Dart product/precompiled modes as the test framework uses dart:mirrors R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d3ccc1f9ba7c353469be6aeff8ccd22c070e7074

Patch Set 1 #

Total comments: 2

Patch Set 2 : code-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/pkg.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 10 months ago (2016-02-25 19:13:07 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1735313002/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/1735313002/diff/1/pkg/pkg.status#newcode218 pkg/pkg.status:218: [ $runtime == dart_precompiled || $runtime == dart_product ...
4 years, 10 months ago (2016-02-25 19:21:53 UTC) #3
siva
https://codereview.chromium.org/1735313002/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/1735313002/diff/1/pkg/pkg.status#newcode218 pkg/pkg.status:218: [ $runtime == dart_precompiled || $runtime == dart_product ] ...
4 years, 10 months ago (2016-02-25 19:31:39 UTC) #4
siva
4 years, 10 months ago (2016-02-25 20:24:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d3ccc1f9ba7c353469be6aeff8ccd22c070e7074 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698