Issue 173523004: Use a better error message for bad status lines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173523004: Use a better error message for bad status lines. (Closed)

Created:
6 years, 10 months ago by Adam Rice

Modified:
6 years, 10 months ago

Reviewers:
tyoshino (SeeGerritForStatus)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Previously, an unparseable status line would give an "Unexpected response code: 200" console error, which didn't make much sense. This is because HttpStreamParser synthesises an "HTTP/0.9 200 OK" status line if it doesn't see the string "HTTP" within the first 8 bytes of the response. Use a specific "Invalid status line" error message in this case instead. BUG=345568 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252536

Patch Set 1 #

Patch Set 2 : Update WebSocketStreamCreateTest.MalformedResponse #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	net/websockets/websocket_basic_handshake_stream.cc	View		1 chunk	+12 lines, -3 lines	0 comments	Download
	M	net/websockets/websocket_stream_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tyoshino (SeeGerritForStatus)

lgtm please write that this clamping is done not in HttpResponseHeaders but in HttpStreamParser in ...

6 years, 10 months ago (2014-02-21 08:04:50 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/173523004/50001

6 years, 10 months ago (2014-02-21 09:33:25 UTC) #4

Message was sent while issue was closed.

Change committed as 252536

Expand Messages | Collapse Messages