Chromium Code Reviews Chromium Code Reviews
Issue
173523003:
Make clearing the animated type at the end of an interval more robust (Closed)
DescriptionMake clearing the animated type at the end of an interval more robust
When an interval of a timed element ends, and said timed element will no
longer contribute to the target element, the animator of the timed element
needs to stopped, and it's state cleared (so that another timed element
may assume that role).
With "linked" syncbases involved, the end of one interval would trigger a
new interval, which in turn allowed resolving yet another interval - which
end up signaling a restart.
Fix by tightening the condition when maybeRestartInterval() returns by
checking if the newly resolved interval is active. Also attempt to make
the condition for when to clear the animator more robust by checking if
the timed element is no longer contributing to the target using
|animationIsContributing|, rather trying to re-deduce it from
the active-state transition + restart (which would observe
'active' -> 'in-active' + restart in this case.)
(Either one of these fix the issue.)
BUG=344408
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167822
Patch Set 1 #
Total comments: 2
Patch Set 2 : Drop explicit timeout in TC. #
Messages
Total messages: 8 (0 generated)
|
|||||||||||||||||||||||||||||||||||||
