Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Issue 1735203002: Revert of Moving proxy resolution logic out of NetworkDelegate and into ProxyDelegate (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 9 months ago
Reviewers:
asanka, bengr, RyanSturm
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Moving proxy resolution logic out of NetworkDelegate and into ProxyDelegate for DataReductionProxy (patchset #6 id:90001 of https://codereview.chromium.org/1680893002/ ) Reason for revert: Most likely cause of failing test on bot: https://bugs.chromium.org/p/chromium/issues/detail?id=589832 Original issue's description: > Moving proxy resolution logic out of NetworkDelegate and into ProxyDelegate for DataReductionProxy > > This involves removing two methods off the NetworkDelegate interface (and four off LayeredNetworkDelegate). DataReductionProxy's logic for these two methods will be moved to the DataReductionProxyDelegate from the DataReductionProxyNetworkDelegate. This also involved cleaning up some unit tests and moving calls to use ProxyDelegate instead of NetworkDelegate where relevant. > > Refactoring proxy related calls from NetworkDelegate to ProxyDelegate > > BUG=583369 > > Committed: https://crrev.com/7de050c68ce2a97c0165d09d06c89b8aff79fb77 > Cr-Commit-Position: refs/heads/master@{#376860} TBR=bengr@chromium.org,asanka@chromium.org,ryansturm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=583369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+646 lines, -749 lines) Patch
M components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h View 4 chunks +1 line, -26 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc View 4 chunks +2 lines, -63 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc View 3 chunks +2 lines, -472 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h View 5 chunks +44 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 5 chunks +67 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 2 chunks +284 lines, -0 lines 0 comments Download
M net/base/layered_network_delegate.h View 3 chunks +15 lines, -0 lines 0 comments Download
M net/base/layered_network_delegate.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M net/base/layered_network_delegate_unittest.cc View 4 chunks +30 lines, -0 lines 0 comments Download
M net/base/network_delegate.h View 3 chunks +22 lines, -0 lines 0 comments Download
M net/base/network_delegate.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M net/base/network_delegate_impl.h View 2 chunks +16 lines, -0 lines 0 comments Download
M net/base/network_delegate_impl.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/proxy/proxy_service.h View 8 chunks +9 lines, -9 lines 0 comments Download
M net/proxy/proxy_service.cc View 18 chunks +48 lines, -34 lines 0 comments Download
M net/proxy/proxy_service_unittest.cc View 12 chunks +25 lines, -58 lines 0 comments Download
M net/url_request/url_request_test_util.h View 2 chunks +0 lines, -8 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M net/websockets/websocket_end_to_end_test.cc View 6 chunks +9 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
agrieve
Created Revert of Moving proxy resolution logic out of NetworkDelegate and into ProxyDelegate for DataReductionProxy
4 years, 10 months ago (2016-02-25 17:06:54 UTC) #1
RyanSturm
On 2016/02/25 17:06:54, agrieve wrote: > Created Revert of Moving proxy resolution logic out of ...
4 years, 10 months ago (2016-02-25 17:11:04 UTC) #2
RyanSturm
On 2016/02/25 17:06:54, agrieve wrote: > Created Revert of Moving proxy resolution logic out of ...
4 years, 10 months ago (2016-02-25 17:11:13 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/27305) cast_shell_android on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-25 17:14:29 UTC) #5
agrieve
On 2016/02/25 17:11:13, Ryan Sturm wrote: > On 2016/02/25 17:06:54, agrieve wrote: > > Created ...
4 years, 10 months ago (2016-02-25 18:26:57 UTC) #6
bengr
4 years, 9 months ago (2016-03-07 22:43:34 UTC) #7
On 2016/02/25 18:26:57, agrieve wrote:
> On 2016/02/25 17:11:13, Ryan Sturm wrote:
> > On 2016/02/25 17:06:54, agrieve wrote:
> > > Created Revert of Moving proxy resolution logic out of NetworkDelegate and
> > into
> > > ProxyDelegate for DataReductionProxy
> > 
> > Fix for this issue is in code review here:
> > https://codereview.chromium.org/1725123005/
> 
> Okay, great!

Seems this CL isn't necessary. Mind closing it?

Powered by Google App Engine
This is Rietveld 408576698