Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1735153002:
Add installer metrics for operations on the archive. (Closed)
|
Created:
4 years, 10 months ago by grt (UTC plus 2) Modified:
4 years, 10 months ago CC:
chromium-reviews, grt+watch_chromium.org, asvitkine+watch_chromium.org, wfh+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd installer metrics for operations on the archive.
BUG=none
Committed: https://crrev.com/af0f476939fbbad4ed6c32548c974c55fe663900
Cr-Commit-Position: refs/heads/master@{#377640}
Patch Set 1 #
Total comments: 8
Patch Set 2 : bcwhite comments #
Messages
Total messages: 18 (10 generated)
Description was changed from ========== Add installer metrics for operations on the archive. BUG=none R=asvitkine@chromium.org ========== to ========== Add installer metrics for operations on the archive. BUG=none R=asvitkine@chromium.org ==========
Description was changed from ========== Add installer metrics for operations on the archive. BUG=none R=asvitkine@chromium.org ========== to ========== Add installer metrics for operations on the archive. BUG=none ==========
grt@chromium.org changed reviewers: + rkaplow@chromium.org - asvitkine@chromium.org
Hi Rob. Please take a look, thanks.
The CQ bit was checked by grt@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735153002/1
bcwhite@chromium.org changed reviewers: + bcwhite@chromium.org
LGTM https://codereview.chromium.org/1735153002/diff/1/chrome/installer/setup/setu... File chrome/installer/setup/setup_main.cc (right): https://codereview.chromium.org/1735153002/diff/1/chrome/installer/setup/setu... chrome/installer/setup/setup_main.cc:268: if (base::PathExists(archive_helper->target())) { Could extract the condition into a bool and have only one instantiation of UMA_HISTOGRAM_BOOLEAN. Each instance is about 15 lines of code and includes a std::map lookup. https://codereview.chromium.org/1735153002/diff/1/chrome/installer/setup/setu... chrome/installer/setup/setup_main.cc:299: SCOPED_UMA_HISTOGRAM_LONG_TIMER("Setup.Install.ApplyArchivePathTime"); ApplyArchivePatchTime (Patch vs Path) https://codereview.chromium.org/1735153002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1735153002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:46250: +<histogram name="Setup.Install.ApplyArchivePathTime" units="ms"> Patch https://codereview.chromium.org/1735153002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:46263: + update is taking place), or false if it contains a full archive (in which No comma.
grt@chromium.org changed reviewers: + jwd@chromium.org - rkaplow@chromium.org
Thanks! https://codereview.chromium.org/1735153002/diff/1/chrome/installer/setup/setu... File chrome/installer/setup/setup_main.cc (right): https://codereview.chromium.org/1735153002/diff/1/chrome/installer/setup/setu... chrome/installer/setup/setup_main.cc:268: if (base::PathExists(archive_helper->target())) { On 2016/02/25 16:46:50, bcwhite wrote: > Could extract the condition into a bool and have only one instantiation of > UMA_HISTOGRAM_BOOLEAN. Each instance is about 15 lines of code and includes a > std::map lookup. Done. https://codereview.chromium.org/1735153002/diff/1/chrome/installer/setup/setu... chrome/installer/setup/setup_main.cc:299: SCOPED_UMA_HISTOGRAM_LONG_TIMER("Setup.Install.ApplyArchivePathTime"); On 2016/02/25 16:46:50, bcwhite wrote: > ApplyArchivePatchTime (Patch vs Path) Done. https://codereview.chromium.org/1735153002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1735153002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:46250: +<histogram name="Setup.Install.ApplyArchivePathTime" units="ms"> On 2016/02/25 16:46:50, bcwhite wrote: > Patch Done. https://codereview.chromium.org/1735153002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:46263: + update is taking place), or false if it contains a full archive (in which On 2016/02/25 16:46:50, bcwhite wrote: > No comma. Done.
histograms LGTM
The CQ bit was checked by grt@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bcwhite@chromium.org Link to the patchset: https://codereview.chromium.org/1735153002/#ps20001 (title: "bcwhite comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735153002/20001
Message was sent while issue was closed.
Description was changed from ========== Add installer metrics for operations on the archive. BUG=none ========== to ========== Add installer metrics for operations on the archive. BUG=none ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add installer metrics for operations on the archive. BUG=none ========== to ========== Add installer metrics for operations on the archive. BUG=none Committed: https://crrev.com/af0f476939fbbad4ed6c32548c974c55fe663900 Cr-Commit-Position: refs/heads/master@{#377640} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/af0f476939fbbad4ed6c32548c974c55fe663900 Cr-Commit-Position: refs/heads/master@{#377640} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
