Add checks to understand crash in NavigationHandle::DidCommitNavigation

content/browser/frame_host/render_frame_host_impl.cc

Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index a6e002acc8ee2c2af88a7be8ff6f2e36f50c9960..3cb274752a7bf9ab28752eb8d235fe69cef3b8a0 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1049,6 +1049,9 @@ void RenderFrameHostImpl::OnDidCommitProvisionalLoad(const IPC::Message& msg) {
     }
   }
 
+  CHECK(navigation_handle_);

[nasko, 2016/02/25 16:47:19]

I don't see how this will be nullptr. It is tested on line 1025 and 1033. If it
was nullptr, it will be allocated on 1035.

[clamy, 2016/02/26 12:41:02]

Removed the check.

+  CHECK_EQ(navigation_handle_->GetURL(), validated_params.url);

[nasko, 2016/02/25 16:47:19]

Same thing here. It is checked on 1026 and if the handle was deleted, the new
one is explicitly initialized with validated_params.url.

[clamy, 2016/02/26 12:41:02]

I know but we're still hitting the check in NavigationHandleImpl (which does not
make much sense to me). This is just temporarily there to ensure that we have
the right values before calling NavigatorImpl::DidNavigate.

+
   accessibility_reset_count_ = 0;
   frame_tree_node()->navigator()->DidNavigate(this, validated_params);