Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1735063004: SkPDF/Bench becnchmark new SkPDFUtils::FloatToDecimal function. (Closed)

Created:
4 years, 10 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : reabse #

Patch Set 3 : 2016-03-09 (Wednesday) 13:28:39 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M bench/PDFBench.cpp View 1 2 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735063004/1
4 years, 10 months ago (2016-02-25 15:26:28 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 15:38:45 UTC) #6
hal.canary
ptal
4 years, 10 months ago (2016-02-25 16:54:55 UTC) #8
mtklein
lgtm https://codereview.chromium.org/1735063004/diff/1/bench/PDFBench.cpp File bench/PDFBench.cpp (right): https://codereview.chromium.org/1735063004/diff/1/bench/PDFBench.cpp#newcode158 bench/PDFBench.cpp:158: SkRandom random(0x5EED); why not the default seed?
4 years, 10 months ago (2016-02-25 17:00:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735063004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735063004/40001
4 years, 9 months ago (2016-03-09 18:31:13 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 18:49:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/cf430139db4bf2f00114903642a884ae81baed4a

Powered by Google App Engine
This is Rietveld 408576698