Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1735033002: Don't use Isolate::Current for AST debugging. (Closed)

Created:
4 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't use Isolate::Current for AST debugging. BUG= R=littledan@chromium.org Committed: https://crrev.com/05ae2db70620bd6ce7f9db811c4c48e704ece04b Cr-Commit-Position: refs/heads/master@{#34294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/ast/ast.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ast/ast.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
4 years, 10 months ago (2016-02-25 12:21:16 UTC) #1
Benedikt Meurer
LGTM (gummistampf)
4 years, 10 months ago (2016-02-25 13:44:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735033002/1
4 years, 10 months ago (2016-02-25 13:45:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 13:50:39 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 13:51:06 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/05ae2db70620bd6ce7f9db811c4c48e704ece04b
Cr-Commit-Position: refs/heads/master@{#34294}

Powered by Google App Engine
This is Rietveld 408576698