Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 173503009: Split generate_global_constructors.py from compute_interfaces_info.py (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Split generate_global_constructors.py from compute_interfaces_info.py Just split generate_global_constructors.py from compute_interfaces_info.py, with common functions (file handling and regex IDL parsing) in utilities.py No logic changes, just split. (Logic changes in followup.) Rationale (for reference): Currently compute_dependencies.py is very complex, doing 3 tasks: 1. Computing interfaces info (main function) 2. Computing global constructors 3. Computing event interfaces This splits out 2 (global constructors); event interfaces will be a followup. The complexity makes the code hard to understand and edit (previous CLs have required extensive review), and makes code reuse hard (e.g., in run-bindings-tests we need to use dummy files b/c we don't care about global constructors). Most seriously, this makes it hard to use compute_dependencies to compute dependencies at gyp time (needed to avoid full rebuilds), since it generates excess files that we only want to generate at build time. Followup to: Rename compute_dependencies.py => compute_interfaces_info.py https://codereview.chromium.org/171373006/ Split from: Split generate_global_constructors.py out of compute_dependencies.py https://codereview.chromium.org/173803006/ BUG=341748 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168094

Patch Set 1 #

Patch Set 2 : Comment #

Patch Set 3 : One missed exception #

Patch Set 4 : [NoHeader] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -290 lines) Patch
M Source/bindings/generated_bindings.gyp View 1 2 3 4 chunks +69 lines, -40 lines 0 comments Download
M Source/bindings/scripts/compute_interfaces_info.py View 1 2 11 chunks +9 lines, -239 lines 0 comments Download
A Source/bindings/scripts/generate_global_constructors.py View 1 2 3 1 chunk +157 lines, -0 lines 0 comments Download
A Source/bindings/scripts/utilities.py View 1 chunk +129 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Nils Barth (inactive)
#2/3
6 years, 10 months ago (2014-02-21 13:06:21 UTC) #1
haraken
LGTM
6 years, 10 months ago (2014-02-21 13:28:20 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-25 01:39:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/173503009/70001
6 years, 10 months ago (2014-02-25 01:41:04 UTC) #4
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 10 months ago (2014-02-25 04:02:06 UTC) #5
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-02-28 02:08:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/173503009/70001
6 years, 9 months ago (2014-02-28 02:09:07 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 02:09:08 UTC) #8
commit-bot: I haz the power
Failed to apply patch for Tools/Scripts/webkitpy/bindings/main.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-02-28 02:09:09 UTC) #9
Nils Barth (inactive)
BTW, need to add [NoHeader] to partial interfaces b/c we've switched to Python. (Recall that ...
6 years, 9 months ago (2014-02-28 03:02:36 UTC) #10
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-02-28 03:03:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/173503009/90001
6 years, 9 months ago (2014-02-28 03:03:19 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 04:49:00 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=29574
6 years, 9 months ago (2014-02-28 04:49:01 UTC) #14
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-02-28 05:27:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/173503009/90001
6 years, 9 months ago (2014-02-28 05:28:00 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 08:21:01 UTC) #17
Message was sent while issue was closed.
Change committed as 168094

Powered by Google App Engine
This is Rietveld 408576698