Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1735023002: docs: use the https version of xcode url (Closed)

Created:
4 years, 10 months ago by tfarina
Modified:
4 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

docs: use the https version of xcode url This patch updates the URL for the Xcode site. The old one just redirects to this one anyway. BUG=None R=sdefresne@chromium.org Committed: https://crrev.com/a3a5b5c9fac3adebb486d4caa4ef11112b509e06 Cr-Commit-Position: refs/heads/master@{#377588}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M docs/mac_build_instructions.md View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
4 years, 10 months ago (2016-02-25 12:19:01 UTC) #1
sdefresne
lgtm https://codereview.chromium.org/1735023002/diff/1/docs/mac_build_instructions.md File docs/mac_build_instructions.md (right): https://codereview.chromium.org/1735023002/diff/1/docs/mac_build_instructions.md#newcode8 docs/mac_build_instructions.md:8: * https://developer.apple.com/xcode, 5+ nit: why not https://developer.apple.com/xcode/download/ instead?
4 years, 10 months ago (2016-02-25 13:20:45 UTC) #2
tfarina
https://codereview.chromium.org/1735023002/diff/1/docs/mac_build_instructions.md File docs/mac_build_instructions.md (right): https://codereview.chromium.org/1735023002/diff/1/docs/mac_build_instructions.md#newcode8 docs/mac_build_instructions.md:8: * https://developer.apple.com/xcode, 5+ On 2016/02/25 13:20:45, sdefresne wrote: > ...
4 years, 10 months ago (2016-02-25 16:22:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1735023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1735023002/1
4 years, 10 months ago (2016-02-25 16:23:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 16:37:39 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 16:39:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3a5b5c9fac3adebb486d4caa4ef11112b509e06
Cr-Commit-Position: refs/heads/master@{#377588}

Powered by Google App Engine
This is Rietveld 408576698