chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc - Issue 1735013004: CREDENTIAL: Only toggle 'skip_zero_click' state if API is used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

Issue 1735013004: CREDENTIAL: Only toggle 'skip_zero_click' state if API is used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ugh. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

diff --git a/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc b/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

index 2f96f7f25034484c945885f2fa144ad893d2cd0e..9453c8a6d4ddce4139f03a5f6864c7181e785db3 100644

--- a/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

+++ b/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc

@@ -406,12 +406,12 @@ IN_PROC_BROWSER_TEST_F(PasswordDialogViewTest,

// Blocked automatic sign-in will not prompt:

scoped_ptr<autofill::PasswordForm> blocked_form(

new autofill::PasswordForm(form));

- client()->NotifyUserAutoSigninBlockedOnFirstRun(std::move(blocked_form));

+ client()->NotifyUserCouldBeAutoSignedIn(std::move(blocked_form));

ASSERT_FALSE(controller()->current_autosignin_prompt());

// Successful login with a distinct form after block will not prompt:

blocked_form.reset(new autofill::PasswordForm(form));

- client()->NotifyUserAutoSigninBlockedOnFirstRun(std::move(blocked_form));

+ client()->NotifyUserCouldBeAutoSignedIn(std::move(blocked_form));

form.username_value = base::ASCIIToUTF16("notpeter@pan.test");

client()->NotifySuccessfulLoginWithExistingPassword(form);

ASSERT_FALSE(controller()->current_autosignin_prompt());

@@ -421,7 +421,7 @@ IN_PROC_BROWSER_TEST_F(PasswordDialogViewTest,

browser()->profile()->GetPrefs()->SetBoolean(

password_manager::prefs::kCredentialsEnableAutosignin, false);

blocked_form.reset(new autofill::PasswordForm(form));

- client()->NotifyUserAutoSigninBlockedOnFirstRun(std::move(blocked_form));

+ client()->NotifyUserCouldBeAutoSignedIn(std::move(blocked_form));

client()->NotifySuccessfulLoginWithExistingPassword(form);

ASSERT_FALSE(controller()->current_autosignin_prompt());

browser()->profile()->GetPrefs()->SetBoolean(

@@ -429,7 +429,7 @@ IN_PROC_BROWSER_TEST_F(PasswordDialogViewTest,

// Successful login with the same form after block will prompt:

blocked_form.reset(new autofill::PasswordForm(form));

- client()->NotifyUserAutoSigninBlockedOnFirstRun(std::move(blocked_form));

+ client()->NotifyUserCouldBeAutoSignedIn(std::move(blocked_form));

client()->NotifySuccessfulLoginWithExistingPassword(form);

ASSERT_TRUE(controller()->current_autosignin_prompt());

}