New GM that exercises gamma-correctness in various parts of the pipeline.

New GM that exercises gamma-correctness in various parts of the pipeline.

Attempts to render 50% grey through many different techniques. Only the first one (black/white dither) is guaranteed to be correct. This serves as ground-truth for all the others (independent of whatever your display may or may not be doing when viewing the output of the GM).

Current tests:
- Texture bilerp
- Texture scale (ie mipmaps)
- Simple paint color
- Gradient
- A handful of Xfer modes
- 50% grey bitmaps, both linear and sRGB

Also includes a bug-fix for sRGB -> Linear bitmap case

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1734983003

Committed: https://skia.googlesource.com/skia/+/9f73a71eec0eb54783f2dcad009aae6aafbe38d5

[Brian Osman, 2016-02-25 22:37:22]

Description was changed from

==========
New GM that exercises gamma-correctness in various parts of the pipeline.

Attempts to render 50% grey through many different techniques. Only the first
one (black/white dither) is guaranteed to be correct. This serves as
ground-truth for all the others (independent of whatever your display may or may
not be doing when viewing the output of the GM).

Current tests:
- Texture bilerp
- Texture scale (ie mipmaps)
- Simple paint color
- Gradient
- A handful of Xfer modes
- 50% grey bitmaps, both linear and sRGB

Also includes a bug-fix for sRGB -> Linear bitmap case

BUG=skia:
==========

to

==========
New GM that exercises gamma-correctness in various parts of the pipeline.

Attempts to render 50% grey through many different techniques. Only the first
one (black/white dither) is guaranteed to be correct. This serves as
ground-truth for all the others (independent of whatever your display may or may
not be doing when viewing the output of the GM).

Current tests:
- Texture bilerp
- Texture scale (ie mipmaps)
- Simple paint color
- Gradient
- A handful of Xfer modes
- 50% grey bitmaps, both linear and sRGB

Also includes a bug-fix for sRGB -> Linear bitmap case

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-02-25 22:38:59]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[Brian Osman, 2016-02-25 22:39:00]

https://codereview.chromium.org/1734983003/diff/1/gm/gamma.cpp
File gm/gamma.cpp (right):

https://codereview.chromium.org/1734983003/diff/1/gm/gamma.cpp#newcode120
gm/gamma.cpp:120: /*    p.setShader(SkShader::CreateBitmapShader(
This is another test I want to add in, but I switched to drawBitmap based on
Mike's feedback. (This path won't work quite yet).

[reed1, 2016-02-25 23:49:33]

lgtm

https://codereview.chromium.org/1734983003/diff/1/src/core/SkBlitter_Sprite.cpp
File src/core/SkBlitter_Sprite.cpp (right):

https://codereview.chromium.org/1734983003/diff/1/src/core/SkBlitter_Sprite.c...
src/core/SkBlitter_Sprite.cpp:64: blitter = SkSpriteBlitter::ChooseNew32(source,
paint, allocator, dst.info().profileType());
nit: breaks 100col limit

[Brian Osman, 2016-02-26 15:06:33]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-02-26 15:06:34]

Double checked all the line lengths, and some column alignment on a few things.

[Brian Osman, 2016-02-26 15:06:34]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1734983003/#ps20001
(title: "Coding standards fixes")

[commit-bot: I haz the power, 2016-02-26 15:06:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1734983003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1734983003/20001

[commit-bot: I haz the power, 2016-02-26 15:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 15:08:11]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[Brian Osman, 2016-02-26 15:15:06]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-02-26 15:15:07]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1734983003/#ps40001
(title: "eraseRGB -> eraseARGB (Deprecated)")

[commit-bot: I haz the power, 2016-02-26 15:15:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1734983003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1734983003/40001

[commit-bot: I haz the power, 2016-02-26 15:16:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-26 15:16:14]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[Brian Osman, 2016-02-26 15:42:49]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-02-26 15:42:49]

Appeasing trybots...

[Brian Osman, 2016-02-26 15:42:50]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1734983003/#ps60001
(title: "Switched to SkString. Better labels for several tests. Added "bitmap
wrapped in shader" to demonstr…")

[commit-bot: I haz the power, 2016-02-26 15:42:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1734983003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1734983003/60001

[commit-bot: I haz the power, 2016-02-26 15:59:35]

Description was changed from

==========
New GM that exercises gamma-correctness in various parts of the pipeline.

Attempts to render 50% grey through many different techniques. Only the first
one (black/white dither) is guaranteed to be correct. This serves as
ground-truth for all the others (independent of whatever your display may or may
not be doing when viewing the output of the GM).

Current tests:
- Texture bilerp
- Texture scale (ie mipmaps)
- Simple paint color
- Gradient
- A handful of Xfer modes
- 50% grey bitmaps, both linear and sRGB

Also includes a bug-fix for sRGB -> Linear bitmap case

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
New GM that exercises gamma-correctness in various parts of the pipeline.

Attempts to render 50% grey through many different techniques. Only the first
one (black/white dither) is guaranteed to be correct. This serves as
ground-truth for all the others (independent of whatever your display may or may
not be doing when viewing the output of the GM).

Current tests:
- Texture bilerp
- Texture scale (ie mipmaps)
- Simple paint color
- Gradient
- A handful of Xfer modes
- 50% grey bitmaps, both linear and sRGB

Also includes a bug-fix for sRGB -> Linear bitmap case

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/9f73a71eec0eb54783f2dcad009aae6aafbe38d5
==========

[commit-bot: I haz the power, 2016-02-26 15:59:36]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/9f73a71eec0eb54783f2dcad009aae6aafbe38d5

[Brian Osman, 2016-02-26 17:18:48]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1744533002/ by brianosman@google.com.

The reason for reverting is: Testing revert to fix MacMini?.