Remove webkit-background-composite

Remove webkit-background-composite

Remove webkit-background-composite as it is a non-standard property
(only supported by WebKit and Blink) and has low usage. Deprecation
message was in M50.

For the blink-dev discussion on this property visit:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/background-composite/blink-dev/thxrbc8XOmc/lu1iZZfNAgAJ

Note: Meant to land after M50 branch point

BUG=498588
Committed: https://crrev.com/2f30bc46e457d9d07312af7b79fbb160fb9c81c4
Cr-Commit-Position: refs/heads/master@{#378607}

[nainar, 2016-02-25 00:52:43]

nainar@chromium.org changed reviewers:
+ alancutter@chromium.org

[nainar, 2016-02-25 00:52:44]

Hi Alan,

PTAL? 

Thanks!

[alancutter (OOO until 2018), 2016-02-25 01:02:35]

lgtm to land after M50 branch point.

[nainar, 2016-02-25 01:05:02]

Description was changed from

==========
Remove webkit-background-composite

Remove webkit-background-composite as it is a non-standard property
(only supported by WebKit and Blink) and has low usage. Deprecation
message was in M50.

For the blink-dev discussion on this property visit:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/backgroun...

BUG=498588
==========

to

==========
Remove webkit-background-composite

Remove webkit-background-composite as it is a non-standard property
(only supported by WebKit and Blink) and has low usage. Deprecation
message was in M50.

For the blink-dev discussion on this property visit:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/backgroun...

Note: Meant to land after M50 branch point

BUG=498588
==========

[nainar, 2016-02-25 01:05:53]

nainar@chromium.org changed reviewers:
+ timloh@chromium.org

[nainar, 2016-02-25 01:05:54]

@alancutter - changed the description to reflect the intent to land after M50
branch point. 

@timloh,

PTAL?

Thanks!

[Timothy Loh, 2016-02-29 02:36:32]

https://codereview.chromium.org/1734863003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1734863003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:59: switch
(unresolvedProperty) {
this doesn't compile on some platforms. maybe we should deprecate more
properties first?

[nainar, 2016-02-29 03:18:33]

@timloh,

PTAL? 

Thanks!

https://codereview.chromium.org/1734863003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1734863003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:59: switch
(unresolvedProperty) {
Returning an empty string for now and leaving a comment to add a switch
statement when needed later.

[Timothy Loh, 2016-02-29 05:55:23]

lgtm

[nainar, 2016-03-01 01:55:09]

The CQ bit was checked by nainar@chromium.org

[nainar, 2016-03-01 01:55:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/1734863003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-03-01 01:55:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1734863003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1734863003/20001

[commit-bot: I haz the power, 2016-03-01 02:14:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 02:14:01]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nainar, 2016-03-01 02:17:36]

nainar@chromium.org changed reviewers:
+ pfeldman@chromium.org

[nainar, 2016-03-01 02:17:36]

@pfeldman, 

PTAL at the change to devtools/front_end/sdk/CSSMetadata.js

Thanks!

[nainar, 2016-03-01 02:20:31]

nainar@chromium.org changed reviewers:
+ rbyers@chromium.org

[nainar, 2016-03-01 02:20:32]

@rbyers, 

PTAL at virtual/stable/webexposed/css-properties-as-js-properties-expected.txt/

Thanks!

[Rick Byers, 2016-03-01 15:50:58]

On 2016/03/01 02:20:32, nainar wrote:
> @rbyers, 
> 
> PTAL at
virtual/stable/webexposed/css-properties-as-js-properties-expected.txt/
> 
> Thanks!

virtual/stable/webexposed LGTM

[Rick Byers, 2016-03-01 15:53:39]

On 2016/03/01 02:17:36, nainar wrote:
> @pfeldman, 
> 
> PTAL at the change to devtools/front_end/sdk/CSSMetadata.js
> 
> Thanks!

I was tempted to rubber-stamp this change as well, but I'm not 100% confident
there aren't versioning implications of changing this since newer devtools can
debug an older target.  It's probably fine (I believe the front-end is
version-specific), but best to get the blessing of a DevTools owner.

[pfeldman, 2016-03-01 19:57:10]

lgtm

[nainar, 2016-03-01 22:21:17]

@rbyers and @pfeldman,

Thank you for the reviews! :)

[nainar, 2016-03-01 22:21:20]

The CQ bit was checked by nainar@chromium.org

[commit-bot: I haz the power, 2016-03-01 22:22:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1734863003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1734863003/20001

[commit-bot: I haz the power, 2016-03-01 23:42:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-01 23:44:14]

Description was changed from

==========
Remove webkit-background-composite

Remove webkit-background-composite as it is a non-standard property
(only supported by WebKit and Blink) and has low usage. Deprecation
message was in M50.

For the blink-dev discussion on this property visit:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/backgroun...

Note: Meant to land after M50 branch point

BUG=498588
==========

to

==========
Remove webkit-background-composite

Remove webkit-background-composite as it is a non-standard property
(only supported by WebKit and Blink) and has low usage. Deprecation
message was in M50.

For the blink-dev discussion on this property visit:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/backgroun...

Note: Meant to land after M50 branch point

BUG=498588

Committed: https://crrev.com/2f30bc46e457d9d07312af7b79fbb160fb9c81c4
Cr-Commit-Position: refs/heads/master@{#378607}
==========

[commit-bot: I haz the power, 2016-03-01 23:44:19]

Patchset 2 (id:??) landed as
https://crrev.com/2f30bc46e457d9d07312af7b79fbb160fb9c81c4
Cr-Commit-Position: refs/heads/master@{#378607}