Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1734863002: Fix git cl format when it finds no clang-formattable files. (Closed)

Created:
4 years, 10 months ago by Sam McNally
Modified:
4 years, 10 months ago
Reviewers:
agable
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix git cl format when it finds no clang-formattable files. Currently, if git cl format does not find any clang-formattable files, either in the path provided on the command line or in the CL as a whole, then it applies clang-format to all changes in the CL. This CL fixes this by changing git cl format to not clang-format when it does not find any changed files that are clang-formattable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M git_cl.py View 1 chunk +20 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Sam McNally
4 years, 10 months ago (2016-02-25 00:54:46 UTC) #4
agable
lgtm
4 years, 10 months ago (2016-02-25 17:04:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734863002/1
4 years, 10 months ago (2016-02-25 22:29:36 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 22:39:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298971

Powered by Google App Engine
This is Rietveld 408576698