xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h - Issue 1734823002: Get rid of CBC_AutoPtr and use std::unique_ptr instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h

Issue 1734823002: Get rid of CBC_AutoPtr and use std::unique_ptr instead. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h

diff --git a/xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h b/xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h

index 63ee10ef06a01ac44fb2cd5bdfc65fa245a96bd0..6146c414656bb7dccc8e0a2fb4914e2e84649885 100644

--- a/xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h

+++ b/xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h

@@ -7,6 +7,8 @@

#ifndef XFA_SRC_FXBARCODE_QRCODE_BC_QRDATABLOCK_H_

#define XFA_SRC_FXBARCODE_QRCODE_BC_QRDATABLOCK_H_

+#include "core/include/fxcrt/fx_basic.h"

dsinclair 2016/02/25 01:56:55 What did you use to find the missing IWYU headers?

Lei Zhang 2016/02/25 02:18:12 Just kept running the compiler and looking at the

class CBC_QRCoderVersion;

class CBC_QRCoderECBlocks;

class CBC_QRCoderECB;