Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1734823002: Get rid of CBC_AutoPtr and use std::unique_ptr instead. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get rid of CBC_AutoPtr and use std::unique_ptr instead. Also fix IWYU in various fxbarcode headers. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2e6864282e65c55ff6809f5aaae011b31c3a361a

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -272 lines) Patch
M xfa/src/fxbarcode/BC_UtilRSS.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_CommonPerspectiveTransform.cpp View 3 chunks +7 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_GlobalHistogramBinarizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_GlobalHistogramBinarizer.cpp View 4 chunks +8 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/common/BC_WhiteRectangleDetector.cpp View 1 2 chunks +20 lines, -25 lines 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomon.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonDecoder.cpp View 7 chunks +45 lines, -63 lines 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/common/reedsolomon/BC_ReedSolomonGF256Poly.cpp View 3 chunks +13 lines, -18 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixBitMatrixParser.cpp View 1 2 chunks +5 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDataBlock.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDecoder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDecoder.cpp View 1 2 chunks +5 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp View 1 8 chunks +33 lines, -31 lines 2 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixReader.h View 1 chunk +3 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixReader.cpp View 1 2 chunks +7 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDReader.h View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDimReader.h View 1 chunk +4 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDimReader.cpp View 1 2 chunks +5 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.h View 1 chunk +4 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/oned/BC_OnedCodaBarReader.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRBitMatrixParser.cpp View 1 2 chunks +8 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCodeReader.h View 2 chunks +7 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCodeReader.cpp View 1 3 chunks +8 lines, -8 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderDecoder.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderDecoder.cpp View 1 2 chunks +5 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderEncoder.h View 2 chunks +4 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderEncoder.cpp View 5 chunks +12 lines, -14 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDataBlock.h View 1 chunk +2 lines, -0 lines 2 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDataBlock.cpp View 1 2 chunks +6 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDetector.h View 2 chunks +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRDetector.cpp View 1 3 chunks +7 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRFinderPatternFinder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRFinderPatternFinder.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRGridSampler.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRGridSampler.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M xfa/src/fxbarcode/utils.h View 1 chunk +0 lines, -37 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
4 years, 10 months ago (2016-02-24 22:47:09 UTC) #2
dsinclair
lgtm https://codereview.chromium.org/1734823002/diff/20001/xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp File xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp (right): https://codereview.chromium.org/1734823002/diff/20001/xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp#newcode156 xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp:156: dimensionRight = Why not .reset() like the others? ...
4 years, 10 months ago (2016-02-25 01:56:55 UTC) #3
Lei Zhang
https://codereview.chromium.org/1734823002/diff/20001/xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp File xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp (right): https://codereview.chromium.org/1734823002/diff/20001/xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp#newcode156 xfa/src/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp:156: dimensionRight = On 2016/02/25 01:56:55, dsinclair wrote: > Why ...
4 years, 10 months ago (2016-02-25 02:18:12 UTC) #4
Lei Zhang
https://codereview.chromium.org/1734823002/diff/20001/xfa/src/fxbarcode/utils.h File xfa/src/fxbarcode/utils.h (left): https://codereview.chromium.org/1734823002/diff/20001/xfa/src/fxbarcode/utils.h#oldcode26 xfa/src/fxbarcode/utils.h:26: explicit CBC_AutoPtr(_Ty* _P = 0) : _Owns(_P != 0), ...
4 years, 10 months ago (2016-02-25 02:19:25 UTC) #5
Lei Zhang
4 years, 10 months ago (2016-02-25 02:20:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2e6864282e65c55ff6809f5aaae011b31c3a361a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698