Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 17348005: Fix register allocation bug in optimized code on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 1340 matching lines...) Expand 10 before | Expand all | Expand 10 after
1351 locs->set_in(2, ShouldEmitStoreBarrier() 1351 locs->set_in(2, ShouldEmitStoreBarrier()
1352 ? Location::WritableRegister() 1352 ? Location::WritableRegister()
1353 : Location::RegisterOrConstant(value())); 1353 : Location::RegisterOrConstant(value()));
1354 break; 1354 break;
1355 case kExternalTypedDataUint8ArrayCid: 1355 case kExternalTypedDataUint8ArrayCid:
1356 case kExternalTypedDataUint8ClampedArrayCid: 1356 case kExternalTypedDataUint8ClampedArrayCid:
1357 case kTypedDataInt8ArrayCid: 1357 case kTypedDataInt8ArrayCid:
1358 case kTypedDataUint8ArrayCid: 1358 case kTypedDataUint8ArrayCid:
1359 case kTypedDataUint8ClampedArrayCid: 1359 case kTypedDataUint8ClampedArrayCid:
1360 case kOneByteStringCid: 1360 case kOneByteStringCid:
1361 locs->set_in(2, Location::RegisterOrSmiConstant(value()));
1362 break;
1363 case kTypedDataInt16ArrayCid: 1361 case kTypedDataInt16ArrayCid:
1364 case kTypedDataUint16ArrayCid: 1362 case kTypedDataUint16ArrayCid:
1365 case kTypedDataInt32ArrayCid: 1363 case kTypedDataInt32ArrayCid:
1366 case kTypedDataUint32ArrayCid: 1364 case kTypedDataUint32ArrayCid:
1367 locs->set_in(2, Location::WritableRegister()); 1365 locs->set_in(2, Location::WritableRegister());
1368 break; 1366 break;
1369 case kTypedDataFloat32ArrayCid: 1367 case kTypedDataFloat32ArrayCid:
1370 case kTypedDataFloat64ArrayCid: // TODO(srdjan): Support Float64 constants. 1368 case kTypedDataFloat64ArrayCid: // TODO(srdjan): Support Float64 constants.
1371 case kTypedDataFloat32x4ArrayCid: 1369 case kTypedDataFloat32x4ArrayCid:
1372 locs->set_in(2, Location::RequiresFpuRegister()); 1370 locs->set_in(2, Location::RequiresFpuRegister());
(...skipping 2241 matching lines...) Expand 10 before | Expand all | Expand 10 after
3614 compiler->GenerateCall(token_pos(), 3612 compiler->GenerateCall(token_pos(),
3615 &label, 3613 &label,
3616 PcDescriptors::kOther, 3614 PcDescriptors::kOther,
3617 locs()); 3615 locs());
3618 __ Drop(2); // Discard type arguments and receiver. 3616 __ Drop(2); // Discard type arguments and receiver.
3619 } 3617 }
3620 3618
3621 } // namespace dart 3619 } // namespace dart
3622 3620
3623 #endif // defined TARGET_ARCH_ARM 3621 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698