Issue 1734773003: Fix for using the strong mode SDK summary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1734773003: Fix for using the strong mode SDK summary. (Closed)

Created:
4 years, 10 months ago by scheglov

Modified:
4 years, 10 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix for using the strong mode SDK summary. I think the fix does the change needed to configure SDK for using the strong mode summary, but I was not able to verify this fully because of the exception with LibraryElementHandle. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3b97d016345d546efc857d0baa2428aa65a0cbad

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -18 lines)			Patch
	M	pkg/analyzer/lib/src/generated/sdk_io.dart	View		4 chunks	+12 lines, -15 lines	0 comments	Download
	M	pkg/analyzer_cli/lib/src/package_analyzer.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

lgtm, thanks! I'll follow up on the exception you were seeing with LibraryElementHandle.

4 years, 10 months ago (2016-02-24 22:49:32 UTC) #2

scheglov

4 years, 10 months ago (2016-02-24 22:50:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3b97d016345d546efc857d0baa2428aa65a0cbad (presubmit successful).