Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 1734753003: Revert of First set of WebUSB layout tests with Mojo service mocks. (Closed)

Created:
4 years, 10 months ago by Dirk Pranke
Modified:
4 years, 10 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of First set of WebUSB layout tests with Mojo service mocks. (patchset #3 id:40001 of https://codereview.chromium.org/1726943002/ ) Reason for revert: Odd, I'm not sure what happened, but these layout tests appear to have passed the trybots and crashed on the waterfall bots: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/39956 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/28655 Original issue's description: > First set of WebUSB layout tests with Mojo service mocks. > > This patch adds a minimal set of layout tests for the WebUSB API that > work by registering mock implementations of the Mojo services the Blink > implementation depends on. Since these mocks are implemented using the > Javascript Mojo bindings they can live right next to the tests that > depend on them. > > BUG=492204 > > Committed: https://crrev.com/a6f677309a7741a1b9d6f6c510ee8282bfbff8c8 > Cr-Commit-Position: refs/heads/master@{#377429} TBR=rockot@chromium.org,reillyg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=492204 Committed: https://crrev.com/55b630ea4b1677d3d67758a8fd2d258a53d0e39e Cr-Commit-Position: refs/heads/master@{#377519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -652 lines) Patch
M third_party/WebKit/LayoutTests/resources/mojo-helpers.js View 1 chunk +9 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/usb/mock-services.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/usb/resources/fake-devices.js View 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js View 1 chunk +0 lines, -354 lines 0 comments Download
D third_party/WebKit/LayoutTests/usb/usb.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/usb/usbDevice.html View 1 chunk +0 lines, -105 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dirk Pranke
Created Revert of First set of WebUSB layout tests with Mojo service mocks.
4 years, 10 months ago (2016-02-25 05:47:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734753003/1
4 years, 10 months ago (2016-02-25 05:48:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 05:53:42 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 05:55:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55b630ea4b1677d3d67758a8fd2d258a53d0e39e
Cr-Commit-Position: refs/heads/master@{#377519}

Powered by Google App Engine
This is Rietveld 408576698