Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: client/isolateserver.py

Issue 1734743002: Do not consider missing command as internal failure. (Closed) Base URL: git@github.com:luci/luci-py.git@master
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/run_isolated.py » ('j') | client/run_isolated.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/isolateserver.py
diff --git a/client/isolateserver.py b/client/isolateserver.py
index e749f3b6bba8f8e28a62e73d42334a3915af79df..cd4ab6576631644faf2925b13ea929e9b47ddb36 100755
--- a/client/isolateserver.py
+++ b/client/isolateserver.py
@@ -110,6 +110,11 @@ class Error(Exception):
pass
+class IsolatedErrorNoCommand(isolated_format.IsolatedError):
+ """Signals an early abort due to lack of command specified."""
+ pass
+
+
class Aborted(Error):
"""Operation aborted."""
pass
@@ -1829,7 +1834,7 @@ def fetch_isolated(isolated_hash, storage, cache, outdir, require_command):
if require_command and not bundle.command:
# TODO(vadimsh): All fetch operations are already enqueue and there's no
# easy way to cancel them.
- raise isolated_format.IsolatedError('No command to run')
+ raise IsolatedErrorNoCommand()
with tools.Profiler('GetRest'):
# Create file system hierarchy.
« no previous file with comments | « no previous file | client/run_isolated.py » ('j') | client/run_isolated.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698